From: Arjan van de Ven <arjanv@redhat.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Brian Gerst <bgerst@didntduck.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i386 do_machine_check() is redundant.
Date: Sun, 28 Sep 2003 21:04:28 +0200 [thread overview]
Message-ID: <1064775868.5045.4.camel@laptop.fenrus.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0309281121470.15408-100000@home.osdl.org>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
On Sun, 2003-09-28 at 20:24, Linus Torvalds wrote:
> On Sun, 28 Sep 2003, Brian Gerst wrote:
> >
> > Use machine_check_vector in the entry code instead.
>
> This is wrong. You just lost the "asmlinkage" thing, which means that it
> breaks when asmlinkage matters.
>
> And yes, asmlinkage _can_ matter, even on x86. It disasbles regparm, for
> one thing, so it makes a huge difference if the kernel is compiled with
> -mregparm=3 (which used to work, and which I'd love to do, but gcc has
> often been a tad fragile).
gcc 3.2 and later are supposed to be ok (eg during 3.2 development a
long standing bug with regparm was fixed and now is believed to work)...
since our makefiles check gcc version already... this can be made gcc
version dependent as well for sure..
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-09-28 19:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-28 16:29 [PATCH] i386 do_machine_check() is redundant Brian Gerst
2003-09-28 18:24 ` Linus Torvalds
2003-09-28 18:30 ` Brian Gerst
2003-09-28 18:34 ` Linus Torvalds
2003-09-28 18:44 ` Brian Gerst
2003-09-28 19:04 ` Arjan van de Ven [this message]
2003-09-29 18:46 ` Linus Torvalds
2003-09-29 19:23 ` Jeff Garzik
2003-09-29 19:54 ` -mregparm=3 (was " Valdis.Kletnieks
2003-09-30 8:28 ` Helge Hafting
2003-09-30 15:29 ` Valdis.Kletnieks
2003-09-30 15:48 ` Linus Torvalds
2003-09-29 20:20 ` Mikulas Patocka
2003-09-29 20:26 ` Daniel Jacobowitz
2003-09-29 21:36 ` Mikulas Patocka
2003-09-29 21:40 ` Daniel Jacobowitz
2003-09-29 21:43 ` Mikulas Patocka
2003-09-29 21:48 ` Jakub Jelinek
2003-09-30 0:24 ` Jamie Lokier
2003-09-30 4:49 ` Valdis.Kletnieks
2003-09-30 4:55 ` Robert Love
2003-09-30 14:37 ` Valdis.Kletnieks
2003-09-30 15:48 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064775868.5045.4.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox