public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	Marcelo Tosatti <marcelo.tosatti@cyclades.com.br>
Subject: Re: [BUG] 2.4.x RT signal leak with kupdated (and maybe others)
Date: Wed, 01 Oct 2003 11:24:01 +0200	[thread overview]
Message-ID: <1065000241.5636.53.camel@gaston> (raw)
In-Reply-To: <20030930182255.GX17274@velociraptor.random>


> That's because nobody else sends signals to the daemons I guess. And
> even if they do the daemon won't clear the pending bitflag, so there's
> no risk to queue more than 1 non-RT entry per signal per daemon like it
> happened with kupdate.

And any daemon can cause the same leak by sending it RT signals... I just
verified sending for example a bunch of 33's (SIGRTMIN) to khubd, that
increased the count permanently.

I agree this should not happen normally, and I suppose only root can do
that and we aren't here to prevent root from shooting itself in the
foot, are we ?

The question is should I spend some time adding some flush_signals() to
the loop of those various kernel daemons I can find or that isn't worth ?

Regarding kupated, dequeue_signal is a better option as we actually care
about the signal, I'm testing a patch it will be there in a few minutes.

Ben.
 


  reply	other threads:[~2003-10-01  9:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-30 16:27 [BUG] 2.4.x RT signal leak with kupdated (and maybe others) Benjamin Herrenschmidt
2003-09-30 17:36 ` Andrea Arcangeli
2003-09-30 17:47   ` Benjamin Herrenschmidt
2003-09-30 18:22     ` Andrea Arcangeli
2003-10-01  9:24       ` Benjamin Herrenschmidt [this message]
2003-10-01  9:32         ` Nigel Cunningham
2003-10-01 14:45         ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1065000241.5636.53.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox