2.6.0-test5 - stuck keys on iBook

2.6.0-test5 - stuck keys on iBook

[cliff white]

Kernel version: latest from ppc.bkbits.net/linuxppc-2.5

Symptom: keyboard diarrhea - single keypress == 3-7 characters.

I've tried reverting drivers/input/keyboards/atkbd.c back to v1.31, doesn't
change anything.

Haven't done much other debug, since i can't successfully login to the system
from console. 

Further information if needed.
Please cc me if you reply from linuxppc-dev, i am not on that group.

cliffw
cliffw@osdl.org

Re: 2.6.0-test5 - stuck keys on iBook

[Tom Rini]

On Tue, Sep 30, 2003 at 02:31:49PM -0700, cliff white wrote:

> 
> Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
> 
> Symptom: keyboard diarrhea - single keypress == 3-7 characters.
> 
> I've tried reverting drivers/input/keyboards/atkbd.c back to v1.31, doesn't
> change anything.

Just FYI, atkbd isn't used on pmacs.

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: 2.6.0-test5 - stuck keys on iBook

[Brice Figureau]

On Tue, 2003-09-30 at 23:31, cliff white wrote:
> Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
> 
> Symptom: keyboard diarrhea - single keypress == 3-7 characters.

I can confirm this problem on my ibook r2.2 with vanilla kernel.org 2.6.0-test6.
No problem with the latest test5 I tried.

Brice

[PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook)

[Brice Figureau]

Hi Cliff,

On Tue, 2003-09-30 at 23:31, cliff white wrote:
> Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
> 
> Symptom: keyboard diarrhea - single keypress == 3-7 characters.

Here is a patch that fixes the keyboard problem. The input layer
REP_DELAY (and REP_PERIOD) were changed from jiffies to ms but the adb
was not updated accordingly.

I hope this will help you.

Brice

--- drivers/macintosh/adbhid.c.orig	2003-10-02 22:39:31.112571794 +0200
+++ drivers/macintosh/adbhid.c	2003-10-02 22:40:22.888120863 +0200
@@ -611,8 +611,8 @@
 		/* HACK WARNING!! This should go away as soon there is an utility
 		 * to control that for event devices.
 		 */
-		adbhid[id]->input.rep[REP_DELAY] = HZ/2;   /* input layer default: HZ/4 */
-		adbhid[id]->input.rep[REP_PERIOD] = HZ/15; /* input layer default: HZ/33 */
+		adbhid[id]->input.rep[REP_DELAY] = 500;   /* input layer default: 250 */
+		adbhid[id]->input.rep[REP_PERIOD] = 66;   /* input layer default:  33 */
 	}
 }
 

Re: [PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook)

[Benjamin Herrenschmidt]

On Fri, 2003-10-03 at 09:40, Brice Figureau wrote:
> Hi Cliff,
> 
> On Tue, 2003-09-30 at 23:31, cliff white wrote:
> > Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
> >
> > Symptom: keyboard diarrhea - single keypress == 3-7 characters.
> 
> Here is a patch that fixes the keyboard problem. The input layer
> REP_DELAY (and REP_PERIOD) were changed from jiffies to ms but the adb
> was not updated accordingly.
> 
> I hope this will help you.

Thanks, I'll test & commit.

Ben.