From: Brice Figureau <brice@tincell.com>
To: cliff white <cliffw@osdl.org>
Cc: linuxppc-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org
Subject: [PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook)
Date: Fri, 03 Oct 2003 09:40:22 +0200 [thread overview]
Message-ID: <1065166822.7878.2.camel@localhost> (raw)
In-Reply-To: <20030930143149.4930ec9c.cliffw@osdl.org>
Hi Cliff,
On Tue, 2003-09-30 at 23:31, cliff white wrote:
> Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
>
> Symptom: keyboard diarrhea - single keypress == 3-7 characters.
Here is a patch that fixes the keyboard problem. The input layer
REP_DELAY (and REP_PERIOD) were changed from jiffies to ms but the adb
was not updated accordingly.
I hope this will help you.
Brice
--- drivers/macintosh/adbhid.c.orig 2003-10-02 22:39:31.112571794 +0200
+++ drivers/macintosh/adbhid.c 2003-10-02 22:40:22.888120863 +0200
@@ -611,8 +611,8 @@
/* HACK WARNING!! This should go away as soon there is an utility
* to control that for event devices.
*/
- adbhid[id]->input.rep[REP_DELAY] = HZ/2; /* input layer default: HZ/4 */
- adbhid[id]->input.rep[REP_PERIOD] = HZ/15; /* input layer default: HZ/33 */
+ adbhid[id]->input.rep[REP_DELAY] = 500; /* input layer default: 250 */
+ adbhid[id]->input.rep[REP_PERIOD] = 66; /* input layer default: 33 */
}
}
next prev parent reply other threads:[~2003-10-03 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-30 21:31 2.6.0-test5 - stuck keys on iBook cliff white
2003-09-30 23:09 ` Tom Rini
2003-10-01 13:48 ` Brice Figureau
2003-10-03 7:40 ` Brice Figureau [this message]
2003-10-03 15:19 ` [PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook) Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1065166822.7878.2.camel@localhost \
--to=brice@tincell.com \
--cc=cliffw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox