Re: 2.4.22 ACPI power off via sysrq not working

[Sylvain Pasche <sylvain_pasche@yahoo.fr>]

Le ven 03/10/2003 à 10:24, Andi Kleen a écrit :
> Sylvain Pasche <sylvain_pasche@yahoo.fr> writes:

> > If I want to halt the system using sys-rq - o key, I get an oops instead
> > of a power down.

> Use this patch.
> 
> diff -u linux/drivers/acpi/system.c-o linux/drivers/acpi/system.c
> --- linux/drivers/acpi/system.c-o	2003-09-07 16:20:44.000000000 +0200
> +++ linux/drivers/acpi/system.c	2003-09-08 21:04:46.000000000 +0200
> @@ -1192,11 +1192,21 @@
>  
>  #if defined(CONFIG_MAGIC_SYSRQ) && defined(CONFIG_PM)
>  
> +static int po_cb_active; 
> +
> +static void acpi_po_tramp(void *x)
> +{ 
> +	acpi_power_off();	
> +} 
> +
>  /* Simple wrapper calling power down function. */
>  static void acpi_sysrq_power_off(int key, struct pt_regs *pt_regs,
>  	struct kbd_struct *kbd, struct tty_struct *tty)
> -{
> -	acpi_power_off();
> +{	
> +	static struct tq_struct tq = { .routine = acpi_po_tramp };
> +	if (po_cb_active++)
> +		return;
> +	schedule_task(&tq); 
>  }
>  
>  struct sysrq_key_op sysrq_acpi_poweroff_op = {
> 
> 
> -Andi

Yes, it works perfectly with it, thanks.
Do you forward it to the acpi maintainer ?

Cheers,

Sylvain