Re: [patch] Input cleanups for 2.5.29 [2/2]

Greg KH
2002-07-30T21:07:37Z

On Tue, Jul 30, 2002 at 03:23:42PM +0200, Vojtech Pavlik wrote:
> -#include <asm/types.h>
> +#include <stdint.h>

Why? I thought we were not including any glibc (or any other libc)
header files when building the kernel?

> - __u16 bustype;
> - __u16 vendor;
> - __u16 product;
> - __u16 version;
> + uint16_t bustype;
> + uint16_t vendor;
> + uint16_t product;
> + uint16_t version;

{sigh} __u16 is _so_ much nicer, and tells the programmer, "Yes I know
this variable needs to be the same size in userspace and in
kernelspace."

Just my two cents.

greg k-h