public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Karl Vogel <karl.vogel@seagha.com>
To: Kevin Corry <kevcorry@us.ibm.com>
Cc: Neil Brown <neilb@cse.unsw.edu.au>,
	Joe Thornber <thornber@sistina.com>,
	linux-kernel@vger.kernel.org
Subject: Re: LVM on md0: raid0_make_request bug: can't convert block across chunks or bigger than 64k
Date: Tue, 21 Oct 2003 18:41:19 +0200	[thread overview]
Message-ID: <1066754478.1205.2.camel@kvo.local.org> (raw)
In-Reply-To: <1066753760.1161.4.camel@kvo.local.org>

> > >  ----------- Diffstat output ------------
> > >  ./drivers/md/dm-table.c |    5 +++++
> > >  1 files changed, 5 insertions(+)
> > >
> > > diff ./drivers/md/dm-table.c~current~ ./drivers/md/dm-table.c
> > > --- ./drivers/md/dm-table.c~current~	2003-10-21 10:05:29.000000000 +1000
> > > +++ ./drivers/md/dm-table.c	2003-10-21 10:06:27.000000000 +1000
> > > @@ -489,6 +489,11 @@ int dm_get_device(struct dm_target *ti,
> > >  		rs->max_sectors =
> > >  			min_not_zero(rs->max_sectors, q->max_sectors);
> > >
> > > +		if (q->merge_bvec_fn)
> > > +			rs->max_sectors =
> > > +				min_not_zero(rs->max_sectors, PAGE_SIZE>>9);
> > > +
> > > +
> > >  		rs->max_phys_segments =
> > >  			min_not_zero(rs->max_phys_segments,
> > >  				     q->max_phys_segments);
> > 
> > This will probably work, as long as raid0 can split a one-page request that 
> > spans a chunk boundary. I'll be interested to see if this solves Karl's 
> > problem.
> 
> Good news... it solves the problem with my setup. I was able to copy
> files off the logical volume (did an md5sum compare to make sure I got
> the complete files.)

Forgot to mention that it generates a compiler warning:

  CC      drivers/md/dm-table.o
drivers/md/dm-table.c: In function `dm_get_device':
drivers/md/dm-table.c:494: warning: comparison of distinct pointer types
lacks a cast

Using:
$ gcc -v
Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/3.3.1/specs
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info --enable-shared --enable-threads=posix
--disable-checking --with-system-zlib --enable-__cxa_atexit
--host=i386-redhat-linux
Thread model: posix
gcc version 3.3.1 20030930 (Red Hat Linux 3.3.1-6)



  reply	other threads:[~2003-10-21 16:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-20 20:35 LVM on md0: raid0_make_request bug: can't convert block across chunks or bigger than 64k Karl Vogel
2003-10-20 21:06 ` Kevin Corry
2003-10-20 21:52   ` Karl Vogel
2003-10-21  0:09     ` Neil Brown
2003-10-21 13:41       ` Kevin Corry
2003-10-21 16:29         ` Karl Vogel
2003-10-21 16:41           ` Karl Vogel [this message]
2003-10-25 20:23       ` LVM on md0: raid0_make_request bug: can't convert block acros s " Karl Vogel
2003-10-27 22:34         ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1066754478.1205.2.camel@kvo.local.org \
    --to=karl.vogel@seagha.com \
    --cc=kevcorry@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@cse.unsw.edu.au \
    --cc=thornber@sistina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox