From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Daniele Pala <dandario@libero.it>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>, paulus@cs.anu.edu.au
Subject: Re: [PPC] Mac mouse emulate buttons
Date: Mon, 27 Oct 2003 03:04:55 +0100 [thread overview]
Message-ID: <1067220294.4154.45.camel@gaston> (raw)
In-Reply-To: <20031026174853.GA350@SuperSoul>
On Sun, 2003-10-26 at 18:48, Daniele Pala wrote:
> Mouse button emulation doesn't work in the console, because the expression
>
> if ((raw_mode = (kbd->kbdmode == VC_RAW)))
>
> never gets true. So i moved the call to mac_hid_mouse_emulate_buttons
> outside the emulate_raw function. Mouse emulation
> sucks, but i'm too poor to buy a 3-buttons mouse :)
>
> I'm not subscribed to the list, please CC me privately
Thanks, Can you CC me further Mac related issues ?
That code should be moved to a separate module, afaik, the input
layer allows stacking of such "filtering" modules now, though
I haven't looked at the details.
Ben.
> Cheers,
> Daniele
>
>
> --- linux-2.6.0-test8/drivers/char/keyboard.c Tue Sep 30 18:43:22 2003
> +++ linux-2.6.0-test8_mod/drivers/char/keyboard.c Sun Oct 26 09:31:50 2003
> @@ -964,11 +964,6 @@
> static int emulate_raw(struct vc_data *vc, unsigned int keycode,
> unsigned char up_flag)
> {
> -#ifdef CONFIG_MAC_EMUMOUSEBTN
> - if (mac_hid_mouse_emulate_buttons(1, keycode, !up_flag))
> - return 0;
> -#endif /* CONFIG_MAC_EMUMOUSEBTN */
> -
> if (keycode > 255 || !x86_keycodes[keycode])
> return -1;
>
> @@ -1039,6 +1034,11 @@
> #endif
>
> rep = (down == 2);
> +
> +#ifdef CONFIG_MAC_EMUMOUSEBTN
> + if(mac_hid_mouse_emulate_buttons(1, keycode, down << 7))
> + return;
> +#endif /* CONFIG_MAC_EMUMOUSEBTN */
>
> if ((raw_mode = (kbd->kbdmode == VC_RAW)))
> if (emulate_raw(vc, keycode, !down << 7))
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2003-10-27 2:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-26 17:48 [PPC] Mac mouse emulate buttons Daniele Pala
2003-10-27 2:04 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1067220294.4154.45.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=dandario@libero.it \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@cs.anu.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox