From: Marcel Holtmann <marcel@holtmann.org>
To: Margit Schubert-While <margitsw@t-online.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hubert Mantel <mantel@suse.de>
Subject: Re: 2.4 Firmware Loader does not work builtin
Date: Thu, 06 Nov 2003 13:05:13 +0100 [thread overview]
Message-ID: <1068120313.25167.55.camel@pegasus> (raw)
In-Reply-To: <5.1.0.14.2.20031106114658.00a881f8@pop.t-online.de>
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
Hi Margit,
> Either it is not supposed to work builtin, in which case, the make
> should only offer it as a module, - or , somebody forgot to adjust
> lib/Makefile and kernel/ksyms.c
the attached patch should fix this problem. Please confirm it and I
resend it to Marcelo.
Regards
Marcel
[-- Attachment #2: patch-2.4.23-pre9-fix-builtin-fw-loader --]
[-- Type: text/x-patch, Size: 1211 bytes --]
diff -urN linux-2.4.23-pre9/kernel/ksyms.c linux-2.4.23-pre9-mh/kernel/ksyms.c
--- linux-2.4.23-pre9/kernel/ksyms.c Thu Nov 6 12:55:27 2003
+++ linux-2.4.23-pre9-mh/kernel/ksyms.c Thu Nov 6 12:57:17 2003
@@ -49,6 +49,7 @@
#include <linux/seq_file.h>
#include <linux/dnotify.h>
#include <linux/crc32.h>
+#include <linux/firmware.h>
#include <asm/checksum.h>
#if defined(CONFIG_PROC_FS)
@@ -572,6 +573,13 @@
EXPORT_SYMBOL(crc32_le);
EXPORT_SYMBOL(crc32_be);
EXPORT_SYMBOL(bitreverse);
+#endif
+
+#ifdef CONFIG_FW_LOADER
+EXPORT_SYMBOL(release_firmware);
+EXPORT_SYMBOL(request_firmware);
+EXPORT_SYMBOL(request_firmware_nowait);
+EXPORT_SYMBOL(register_firmware);
#endif
/* software interrupts */
diff -urN linux-2.4.23-pre9/lib/firmware_class.c linux-2.4.23-pre9-mh/lib/firmware_class.c
--- linux-2.4.23-pre9/lib/firmware_class.c Thu Nov 6 12:55:27 2003
+++ linux-2.4.23-pre9-mh/lib/firmware_class.c Thu Nov 6 12:56:11 2003
@@ -565,7 +565,9 @@
module_init(firmware_class_init);
module_exit(firmware_class_exit);
+#ifndef CONFIG_FW_LOADER
EXPORT_SYMBOL(release_firmware);
EXPORT_SYMBOL(request_firmware);
EXPORT_SYMBOL(request_firmware_nowait);
EXPORT_SYMBOL(register_firmware);
+#endif
next prev parent reply other threads:[~2003-11-06 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-06 11:01 2.4 Firmware Loader does not work builtin Margit Schubert-While
2003-11-06 12:05 ` Marcel Holtmann [this message]
[not found] ` <Pine.LNX.4.44.0311101057240.16790-100000@logos.cnet>
2003-11-11 20:56 ` Margit Schubert-While
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1068120313.25167.55.camel@pegasus \
--to=marcel@holtmann.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mantel@suse.de \
--cc=margitsw@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox