public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: lib.a causing modules not to load
Date: 08 Nov 2003 09:16:10 -0600	[thread overview]
Message-ID: <1068304571.2048.5.camel@mulgrave> (raw)
In-Reply-To: <20031108085152.B18856@infradead.org>

On Sat, 2003-11-08 at 02:51, Christoph Hellwig wrote:
> On Fri, Nov 07, 2003 at 08:34:19PM -0800, Andrew Morton wrote:
> > How about we just link that function into the kernel and be done with it? 
> > We'll waste a few bytes on SMP machines which have neither ext2 nor ext3
> > linked-in or loaded as modules, but that doesn't sound very important...
> > 
> > (We don't have a kernel/random-support-stuff.c, but we have
> > mm/random-support-stuff.c which for some reason is called mm/swap.c, so
> > I put it there).
> 
> Well, this solves the problem for this particular case, but not other
> stuff in lib for other situations.

I agree...there's much more in lib than just percpu_counter_mod.

> We should just stop building lib
> as archive and conditionalize building bigger and rarely used stuff in
> there using Kconfig symbols.

Actually, I do think lib serves a purpose for shared routines that are
used in disparate places throughout the kernel.

Why code these as Kconfig symbol dependencies when the library mechanism
does exactly what we want except for this one all symbols are in modules
case.  As a counter example: kobject is in lib...Imagine exactly how
many Kconfig conditions we'd have to introduce to conditionalise that...

I really think the correct way forwards is to fix the one failing case;
I was just asking if anyone had already thought about it.

James






  reply	other threads:[~2003-11-08 15:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-07 16:21 lib.a causing modules not to load James Bottomley
2003-11-07 16:27 ` James Bottomley
2003-11-08  4:34 ` Andrew Morton
2003-11-08  8:51   ` Christoph Hellwig
2003-11-08 15:16     ` James Bottomley [this message]
2003-11-17  2:47       ` Rusty Russell
2003-11-18 16:25         ` James Bottomley
2003-11-19  0:06           ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1068304571.2048.5.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox