From: Robert Love <rml@tech9.net>
To: Margit Schubert-While <margitsw@t-online.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.23pre mm/slab.c error
Date: Sat, 08 Nov 2003 19:31:12 -0500 [thread overview]
Message-ID: <1068337871.27320.222.camel@localhost> (raw)
In-Reply-To: <5.1.0.14.2.20031107093114.00a8bec8@pop.t-online.de>
On Fri, 2003-11-07 at 03:36, Margit Schubert-While wrote:
> At lines 1786 to 1793 in mm/slab.c we have :
> while (p != &searchp->slabs_free) {
> #if DEBUG
> slabp = list_entry(p, slab_t, list);
>
> if (slabp->inuse)
> BUG();
> #endif
> full_free++;
>
> I think the "slabp =" should be above the "#if DEBUG".
> Or ?
Looks to me like nothing else uses slabp here but that if, so it is fine
to move it inside the DEBUG. It was outside the DEBUG in 2.4.22 and
earlier kernels, but moving it inside seems a safe optimization to me.
slabp is not used again until line ~1840, where it is given a new value.
Robert Love
prev parent reply other threads:[~2003-11-09 0:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-07 8:36 2.4.23pre mm/slab.c error Margit Schubert-While
2003-11-09 0:31 ` Robert Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1068337871.27320.222.camel@localhost \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=margitsw@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox