* [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783
@ 2003-11-10 21:35 Ramón Rey Vicente
2003-11-10 22:04 ` Andrew Morton
2003-11-11 0:42 ` Gerardo Exequiel Pozzi
0 siblings, 2 replies; 4+ messages in thread
From: Ramón Rey Vicente @ 2003-11-10 21:35 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org; +Cc: Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
Hi.
Trying to scan de ide-scsi devices of my system, I get this
arq->state 4
Badness in as_put_request at drivers/block/as-iosched.c:1783
Call Trace:
[<c01dc908>] as_put_request+0x48/0xa0
[<c01d47d3>] elv_put_request+0x13/0x20
[<c01d69f2>] __blk_put_request+0x52/0xa0
[<c01d6a61>] blk_put_request+0x21/0x40
[<c01d9d0e>] sg_io+0x2ee/0x440
[<c01da5c0>] scsi_cmd_ioctl+0x3c0/0x480
[<c0124b49>] update_process_times+0x29/0x40
[<c011949c>] schedule+0x31c/0x620
[<d093bb65>] cdrom_ioctl+0x25/0xd60 [cdrom]
[<c012eb33>] do_clock_nanosleep+0x1b3/0x300
[<c0119800>] default_wake_function+0x0/0x20
[<c01d86fa>] blkdev_ioctl+0x7a/0x383
[<c01584be>] block_ioctl+0x1e/0x40
[<c016158f>] sys_ioctl+0xef/0x260
[<c0257c57>] syscall_call+0x7/0xb
--
Ramón Rey Vicente <ramon dot rey at hispalinux dot es>
jabber ID <rreylinux at jabber dot org>
GPG public key ID 0xBEBD71D5 -> http://pgp.escomposlinux.org/
[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783
2003-11-10 21:35 [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783 Ramón Rey Vicente
@ 2003-11-10 22:04 ` Andrew Morton
2003-11-11 1:20 ` Nick Piggin
2003-11-11 0:42 ` Gerardo Exequiel Pozzi
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2003-11-10 22:04 UTC (permalink / raw)
To: Ramón Rey Vicente; +Cc: linux-kernel, Nick Piggin
Ramón Rey Vicente <ramon.rey@hispalinux.es> wrote:
>
> Hi.
>
> Trying to scan de ide-scsi devices of my system, I get this
>
> arq->state 4
> Badness in as_put_request at drivers/block/as-iosched.c:1783
> Call Trace:
> [<c01dc908>] as_put_request+0x48/0xa0
> [<c01d47d3>] elv_put_request+0x13/0x20
> [<c01d69f2>] __blk_put_request+0x52/0xa0
> [<c01d6a61>] blk_put_request+0x21/0x40
> [<c01d9d0e>] sg_io+0x2ee/0x440
> [<c01da5c0>] scsi_cmd_ioctl+0x3c0/0x480
> [<c0124b49>] update_process_times+0x29/0x40
> [<c011949c>] schedule+0x31c/0x620
> [<d093bb65>] cdrom_ioctl+0x25/0xd60 [cdrom]
> [<c012eb33>] do_clock_nanosleep+0x1b3/0x300
> [<c0119800>] default_wake_function+0x0/0x20
> [<c01d86fa>] blkdev_ioctl+0x7a/0x383
> [<c01584be>] block_ioctl+0x1e/0x40
> [<c016158f>] sys_ioctl+0xef/0x260
> [<c0257c57>] syscall_call+0x7/0xb
It looks to me that a simple set_request()/put_request() will always do
this.
Nick?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783
2003-11-10 22:04 ` Andrew Morton
@ 2003-11-11 1:20 ` Nick Piggin
0 siblings, 0 replies; 4+ messages in thread
From: Nick Piggin @ 2003-11-11 1:20 UTC (permalink / raw)
To: Andrew Morton; +Cc: Ramón Rey Vicente, linux-kernel
Andrew Morton wrote:
>Ramón Rey Vicente <ramon.rey@hispalinux.es> wrote:
>
>>Hi.
>>
>>Trying to scan de ide-scsi devices of my system, I get this
>>
>>arq->state 4
>>Badness in as_put_request at drivers/block/as-iosched.c:1783
>>Call Trace:
>> [<c01dc908>] as_put_request+0x48/0xa0
>> [<c01d47d3>] elv_put_request+0x13/0x20
>> [<c01d69f2>] __blk_put_request+0x52/0xa0
>> [<c01d6a61>] blk_put_request+0x21/0x40
>> [<c01d9d0e>] sg_io+0x2ee/0x440
>> [<c01da5c0>] scsi_cmd_ioctl+0x3c0/0x480
>> [<c0124b49>] update_process_times+0x29/0x40
>> [<c011949c>] schedule+0x31c/0x620
>> [<d093bb65>] cdrom_ioctl+0x25/0xd60 [cdrom]
>> [<c012eb33>] do_clock_nanosleep+0x1b3/0x300
>> [<c0119800>] default_wake_function+0x0/0x20
>> [<c01d86fa>] blkdev_ioctl+0x7a/0x383
>> [<c01584be>] block_ioctl+0x1e/0x40
>> [<c016158f>] sys_ioctl+0xef/0x260
>> [<c0257c57>] syscall_call+0x7/0xb
>>
>
>It looks to me that a simple set_request()/put_request() will always do
>this.
>
>Nick?
>
Yes. I suppose just add a check for PRESCHED there as well. This
actually can happen in ll_rw_blk.c as well and its pretty hard to
change.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783
2003-11-10 21:35 [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783 Ramón Rey Vicente
2003-11-10 22:04 ` Andrew Morton
@ 2003-11-11 0:42 ` Gerardo Exequiel Pozzi
1 sibling, 0 replies; 4+ messages in thread
From: Gerardo Exequiel Pozzi @ 2003-11-11 0:42 UTC (permalink / raw)
To: Ramón Rey Vicente; +Cc: linux-kernel
On Mon, 10 Nov 2003 22:35:35 +0100, Ramón Rey Vicente wrote:
>Hi.
>
>Trying to scan de ide-scsi devices of my system, I get this
>
>arq->state 4
>Badness in as_put_request at drivers/block/as-iosched.c:1783
>Call Trace:
> [<c01dc908>] as_put_request+0x48/0xa0
> [<c01d47d3>] elv_put_request+0x13/0x20
> [<c01d69f2>] __blk_put_request+0x52/0xa0
> [<c01d6a61>] blk_put_request+0x21/0x40
> [<c01d9d0e>] sg_io+0x2ee/0x440
> [<c01da5c0>] scsi_cmd_ioctl+0x3c0/0x480
> [<c0124b49>] update_process_times+0x29/0x40
> [<c011949c>] schedule+0x31c/0x620
> [<d093bb65>] cdrom_ioctl+0x25/0xd60 [cdrom]
> [<c012eb33>] do_clock_nanosleep+0x1b3/0x300
> [<c0119800>] default_wake_function+0x0/0x20
> [<c01d86fa>] blkdev_ioctl+0x7a/0x383
> [<c01584be>] block_ioctl+0x1e/0x40
> [<c016158f>] sys_ioctl+0xef/0x260
> [<c0257c57>] syscall_call+0x7/0xb
>--
>Ramón Rey Vicente <ramon dot rey at hispalinux dot es>
> jabber ID <rreylinux at jabber dot org>
>GPG public key ID 0xBEBD71D5 -> http://pgp.escomposlinux.org/
>
I resolved this issue with this patch from Nick.
On Mon, 10 Nov 2003 11:53:28 +1100, Nick Piggin wrote:
>Thanks for the report guys,
>Please test the following patch with mm2 and let me know if you still
>have problems with it.
>
>Nick
>
>
linux-2.6-npiggin/drivers/block/as-iosched.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff -puN drivers/block/as-iosched.c~as-full drivers/block/as-iosched.c
--- linux-2.6/drivers/block/as-iosched.c~as-full 2003-11-08 01:40:49.000000000 +1100
+++ linux-2.6-npiggin/drivers/block/as-iosched.c 2003-11-08 02:04:45.000000000 +1100
@@ -962,7 +962,7 @@ static void as_completed_request(request
}
if (!blk_fs_request(rq))
- return;
+ goto out;
if (ad->changed_batch && ad->nr_dispatched == 1) {
WARN_ON(ad->batch_data_dir == arq->is_sync);
@@ -982,7 +982,6 @@ static void as_completed_request(request
* and writeback caches
*/
if (ad->new_batch && ad->batch_data_dir == arq->is_sync) {
- WARN_ON(ad->batch_data_dir != REQ_SYNC);
update_write_batch(ad);
ad->current_batch_expires = jiffies +
ad->batch_expire[REQ_SYNC];
@@ -1508,8 +1507,10 @@ as_insert_request(request_queue_t *q, st
/* barriers must flush the reorder queue */
if (unlikely(rq->flags & (REQ_SOFTBARRIER | REQ_HARDBARRIER)
- && where == ELEVATOR_INSERT_SORT))
+ && where == ELEVATOR_INSERT_SORT)) {
+ WARN_ON(1);
where = ELEVATOR_INSERT_BACK;
+ }
switch (where) {
case ELEVATOR_INSERT_BACK:
chau,
djgera
--
Gerardo Exequiel Pozzi ( djgera )
http://www.vmlinuz.com.ar http://www.djgera.com.ar
KeyID: 0x1B8C330D
Key fingerprint = 0CAA D5D4 CD85 4434 A219 76ED 39AB 221B 1B8C 330D
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-11-11 1:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-10 21:35 [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783 Ramón Rey Vicente
2003-11-10 22:04 ` Andrew Morton
2003-11-11 1:20 ` Nick Piggin
2003-11-11 0:42 ` Gerardo Exequiel Pozzi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox