From: Len Brown <len.brown@intel.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: Eduard Bloch <edi@gmx.de>,
linux-kernel@vger.kernel.org, davej@redhat.com
Subject: Re: not fixed in 2.4.23-rc3 (was: Re: 2.4.22 SMP kernel build for hyper threading P4)
Date: 24 Nov 2003 11:49:18 -0500 [thread overview]
Message-ID: <1069692557.3035.17.camel@dhcppc4> (raw)
In-Reply-To: <20031124070016.GX22764@holomorphy.com>
On Mon, 2003-11-24 at 02:00, William Lee Irwin III wrote:
> A similar (but more elaborate) fix is in 2.6.
Why is the additional variable "kicked" in 2.6 necessary?
Appears that kicked == (cpucount + 1), and the loop already
compares that to NR_CPUS via max_cpus:
if (max_cpus <= cpucount+1)
continue;
Though I think it would read more clearly this way:
if (cpucount + 1 >= max_cpus)
break;
Speaking of max_cpus, it would probably be a good thing if maxcpus() did
not allow the administrator to set max_cpus > NR_CPUS at boot time.
cheers,
-Len
next prev parent reply other threads:[~2003-11-24 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-23 20:16 not fixed in 2.4.23-rc3 (was: Re: 2.4.22 SMP kernel build for hyper threading P4) Brown, Len
2003-11-23 20:45 ` Eduard Bloch
2003-11-24 6:19 ` Len Brown
2003-11-24 7:00 ` William Lee Irwin III
2003-11-24 16:49 ` Len Brown [this message]
2003-11-24 22:55 ` William Lee Irwin III
2003-11-30 9:28 ` Eduard Bloch
-- strict thread matches above, loose matches on Subject: below --
2003-11-15 15:40 2.4.22 SMP kernel build for hyper threading P4 Job 317
2003-11-15 16:40 ` Eduard Bloch
2003-11-23 15:06 ` not fixed in 2.4.23-rc3 (was: Re: 2.4.22 SMP kernel build for hyper threading P4) Eduard Bloch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1069692557.3035.17.camel@dhcppc4 \
--to=len.brown@intel.com \
--cc=davej@redhat.com \
--cc=edi@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox