From: Mingming Cao <cmm@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, marcelo.tosatti@cyclades.com,
Paul.McKenney@us.ibm.com
Subject: Re: [BUG]Missing i_sb NULL pointer check in destroy_inode()
Date: 24 Nov 2003 12:10:15 -0800 [thread overview]
Message-ID: <1069704617.16649.19508.camel@localhost.localdomain> (raw)
In-Reply-To: <20031124112718.1e650478.akpm@osdl.org>
On Mon, 2003-11-24 at 11:27, Andrew Morton wrote:
> Mingming Cao <cmm@us.ibm.com> wrote:
> >
> > destroy_inode() dereferences inode->i_sb without checking if it is NULL.
> > This is inconsistent with its caller: iput() and clear_inode(), both of
> > which check inode->i_sb before dereferencing it.
>
> I assume this has only been observed with an out-of-tree filesystem, but
> yes, the consistency is good.
>
Yes, the crash happened with an out-of-tree filesystem. Thanks.
-Mingming
next prev parent reply other threads:[~2003-11-24 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1068045518.10730.266.camel@socrates>
[not found] ` <20031105181600.GC18278@thunk.org>
[not found] ` <1068066524.10726.289.camel@socrates>
[not found] ` <20031106033817.GB22081@thunk.org>
[not found] ` <1068145132.10735.322.camel@socrates>
[not found] ` <20031106123922.Y10197@schatzie.adilger.int>
[not found] ` <1068148881.10730.337.camel@socrates>
[not found] ` <1068230146.10726.359.camel@socrates>
[not found] ` <20031109130826.2b37219d.akpm@osdl.org>
[not found] ` <1068419747.687.28.camel@socrates>
[not found] ` <20031109152936.3a9ffb69.akpm@osdl.org>
2003-11-24 19:00 ` [BUG]Missing i_sb NULL pointer check in destroy_inode() Mingming Cao
2003-11-24 19:27 ` Andrew Morton
2003-11-24 20:10 ` Mingming Cao [this message]
2003-11-25 8:36 ` Christoph Hellwig
2003-11-26 22:09 ` Mingming Cao
2003-11-27 1:10 ` Timo Kamph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1069704617.16649.19508.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=Paul.McKenney@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox