From: Laurence Oberman <loberman@redhat.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Eli Cohen <eli@mellanox.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Or Gerlitz <ogerlitz@mellanox.com>,
Matan Barak <matanb@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Subject: Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
Date: Tue, 23 Aug 2016 23:35:05 -0400 (EDT) [thread overview]
Message-ID: <1070024890.2212210.1472009705267.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160823201626.13926-1-chris@chris-wilson.co.uk>
----- Original Message -----
> From: "Chris Wilson" <chris@chris-wilson.co.uk>
> To: linux-rdma@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org, "Chris Wilson" <chris@chris-wilson.co.uk>, "Eli Cohen" <eli@mellanox.com>, "Jack
> Morgenstein" <jackm@dev.mellanox.co.il>, "Or Gerlitz" <ogerlitz@mellanox.com>, "Matan Barak" <matanb@mellanox.com>,
> "Leon Romanovsky" <leonro@mellanox.com>, "Doug Ledford" <dledford@redhat.com>, "Sean Hefty" <sean.hefty@intel.com>,
> "Hal Rosenstock" <hal.rosenstock@gmail.com>
> Sent: Tuesday, August 23, 2016 4:16:26 PM
> Subject: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
>
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
>
> The include existed since its inception in
>
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli@mellanox.com>
> Date: Sun Jul 7 17:25:49 2013 +0300
>
> mlx5: Add driver for Mellanox Connect-IB adapters
>
> which looks like a copy across from the Mellanox ethernet driver.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Eli Cohen <eli@mellanox.com>
> Cc: Jack Morgenstein <jackm@dev.mellanox.co.il>
> Cc: Or Gerlitz <ogerlitz@mellanox.com>
> Cc: Matan Barak <matanb@mellanox.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>
> Cc: Doug Ledford <dledford@redhat.com>
> Cc: Sean Hefty <sean.hefty@intel.com>
> Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
> Cc: linux-rdma@vger.kernel.org
> ---
> drivers/infiniband/hw/mlx5/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/main.c
> b/drivers/infiniband/hw/mlx5/main.c
> index a84bb766fc62..1b4094baa2de 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -37,7 +37,6 @@
> #include <linux/pci.h>
> #include <linux/dma-mapping.h>
> #include <linux/slab.h>
> -#include <linux/io-mapping.h>
> #if defined(CONFIG_X86)
> #include <asm/pat.h>
> #endif
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
I compiled and tested this with no issues on my mlx5 test bed.
Reviewed-by Laurence Oberman <loberman@redhat.com>
Tested-by Laurence Oberman <loberman@redhat.com>
prev parent reply other threads:[~2016-08-24 3:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 20:16 [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h Chris Wilson
2016-08-23 21:15 ` Leon Romanovsky
2016-08-23 21:24 ` Chris Wilson
2016-08-24 3:35 ` Laurence Oberman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1070024890.2212210.1472009705267.JavaMail.zimbra@redhat.com \
--to=loberman@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=dledford@redhat.com \
--cc=eli@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=jackm@dev.mellanox.co.il \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox