From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752548AbcHXDgJ (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 Aug 2016 23:36:09 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:37448 "EHLO
        mx4-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751055AbcHXDgG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 Aug 2016 23:36:06 -0400
Date: Tue, 23 Aug 2016 23:35:05 -0400 (EDT)
From: Laurence Oberman <loberman@redhat.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Eli Cohen <eli@mellanox.com>,
        Jack Morgenstein <jackm@dev.mellanox.co.il>,
        Or Gerlitz <ogerlitz@mellanox.com>, Matan Barak <matanb@mellanox.com>,
        Leon Romanovsky <leonro@mellanox.com>,
        Doug Ledford <dledford@redhat.com>, Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>
Message-ID: <1070024890.2212210.1472009705267.JavaMail.zimbra@redhat.com>
In-Reply-To: <20160823201626.13926-1-chris@chris-wilson.co.uk>
References: <20160823201626.13926-1-chris@chris-wilson.co.uk>
Subject: Re: [PATCH] infiniband/mlx5: Remove superfluous include of
 io-mapping.h
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.3.230.215]
X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF45 (Linux)/8.0.6_GA_5922)
Thread-Topic: infiniband/mlx5: Remove superfluous include of io-mapping.h
Thread-Index: +amjr0GSA/XnfE2uoGkKeehmv94SLA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



----- Original Message -----
> From: "Chris Wilson" <chris@chris-wilson.co.uk>
> To: linux-rdma@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org, "Chris Wilson" <chris@chris-wilson.co.uk>, "Eli Cohen" <eli@mellanox.com>, "Jack
> Morgenstein" <jackm@dev.mellanox.co.il>, "Or Gerlitz" <ogerlitz@mellanox.com>, "Matan Barak" <matanb@mellanox.com>,
> "Leon Romanovsky" <leonro@mellanox.com>, "Doug Ledford" <dledford@redhat.com>, "Sean Hefty" <sean.hefty@intel.com>,
> "Hal Rosenstock" <hal.rosenstock@gmail.com>
> Sent: Tuesday, August 23, 2016 4:16:26 PM
> Subject: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
> 
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
> 
> The include existed since its inception in
> 
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli@mellanox.com>
> Date:   Sun Jul 7 17:25:49 2013 +0300
> 
>     mlx5: Add driver for Mellanox Connect-IB adapters
> 
> which looks like a copy across from the Mellanox ethernet driver.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Eli Cohen <eli@mellanox.com>
> Cc: Jack Morgenstein <jackm@dev.mellanox.co.il>
> Cc: Or Gerlitz <ogerlitz@mellanox.com>
> Cc: Matan Barak <matanb@mellanox.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>
> Cc: Doug Ledford <dledford@redhat.com>
> Cc: Sean Hefty <sean.hefty@intel.com>
> Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
> Cc: linux-rdma@vger.kernel.org
> ---
>  drivers/infiniband/hw/mlx5/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mlx5/main.c
> b/drivers/infiniband/hw/mlx5/main.c
> index a84bb766fc62..1b4094baa2de 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -37,7 +37,6 @@
>  #include <linux/pci.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/slab.h>
> -#include <linux/io-mapping.h>
>  #if defined(CONFIG_X86)
>  #include <asm/pat.h>
>  #endif
> --
> 2.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
I compiled and tested this with no issues on my mlx5 test bed.

Reviewed-by Laurence Oberman <loberman@redhat.com>
Tested-by Laurence Oberman <loberman@redhat.com>