From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761959AbXGJCYr (ORCPT ); Mon, 9 Jul 2007 22:24:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762120AbXGJCYZ (ORCPT ); Mon, 9 Jul 2007 22:24:25 -0400 Received: from mx1.suse.de ([195.135.220.2]:38085 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762117AbXGJCYY (ORCPT ); Mon, 9 Jul 2007 22:24:24 -0400 From: NeilBrown To: Andrew Morton Date: Tue, 10 Jul 2007 12:24:20 +1000 Message-Id: <1070710022420.13110@suse.de> X-face: [Gw_3E*Gng}4rRrKRYotwlE?.2|**#s9D Cc: J "." Bruce Fields Cc: Neil Brown Subject: [PATCH 006 of 20] knfsd: nfsd: remove superfluous assignment from nfsd_lookup References: <20070710121949.12548.patches@notabene> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org From: J. Bruce Fields The "err" variable will only be used in the final return, which always happens after either the preceding err = fh_compose(...); or after the following err = nfserrno(host_err); So the earlier assignment to err is ignored. Signed-off-by: "J. Bruce Fields" Signed-off-by: Neil Brown ### Diffstat output ./fs/nfsd/vfs.c | 2 -- 1 file changed, 2 deletions(-) diff .prev/fs/nfsd/vfs.c ./fs/nfsd/vfs.c --- .prev/fs/nfsd/vfs.c 2007-07-10 11:20:09.000000000 +1000 +++ ./fs/nfsd/vfs.c 2007-07-10 11:34:00.000000000 +1000 @@ -168,8 +168,6 @@ nfsd_lookup(struct svc_rqst *rqstp, stru exp = fhp->fh_export; exp_get(exp); - err = nfserr_acces; - /* Lookup the name, but don't follow links */ if (isdotent(name, len)) { if (len==1)