From: Greg KH <greg@kroah.com>
To: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB Fixes for 2.6.0-test11
Date: Wed, 10 Dec 2003 17:29:05 -0800 [thread overview]
Message-ID: <10711061451952@kroah.com> (raw)
In-Reply-To: <10711061453801@kroah.com>
ChangeSet 1.1517, 2003/12/08 13:28:46-08:00, david-b@pacbell.net
[PATCH] USB: fix remove device after set_configuration
If a device can't be configured, the current test9 code forgets
to clean it out of sysfs. This resolves that issue, so the retry
in usb_new_device() stands a chance of working.
The enumeration code still doesn't handle such errors well, but
at least this way that hub port can be used for another device.
drivers/usb/core/usb.c | 1 +
1 files changed, 1 insertion(+)
diff -Nru a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
--- a/drivers/usb/core/usb.c Wed Dec 10 16:47:58 2003
+++ b/drivers/usb/core/usb.c Wed Dec 10 16:47:58 2003
@@ -1120,6 +1120,7 @@
if (err) {
dev_err(&dev->dev, "can't set config #%d, error %d\n",
dev->config[0].desc.bConfigurationValue, err);
+ device_del(&dev->dev);
goto fail;
}
next prev parent reply other threads:[~2003-12-11 1:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-11 1:27 [BK PATCH] USB Fixes for 2.6.0-test11 Greg KH
2003-12-11 1:29 ` [PATCH] " Greg KH
2003-12-11 1:29 ` Greg KH [this message]
2003-12-11 1:29 ` Greg KH
2003-12-11 1:29 ` Greg KH
2003-12-11 1:29 ` Greg KH
2003-12-11 1:29 ` Greg KH
2003-12-11 1:29 ` Greg KH
2003-12-11 1:29 ` Greg KH
2003-12-11 1:29 ` Greg KH
2003-12-11 1:29 ` Greg KH
2003-12-11 1:29 ` Greg KH
2003-12-11 17:56 ` [BK PATCH] Kobject Fix " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10711061451952@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox