public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@clear.net.nz>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Witold Krecicki <adasi@kernel.pl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Suspend not working with SATA:
Date: Tue, 16 Dec 2003 07:22:28 +1300	[thread overview]
Message-ID: <1071512548.14229.88.camel@laptop-linux> (raw)
In-Reply-To: <3FDDD0B0.60807@pobox.com>

Hi.

Set PF_IOTHREAD on the task's flags instead. That will allow it to run
during suspending.

Regards,

Nigel

On Tue, 2003-12-16 at 04:18, Jeff Garzik wrote:
> Witold Krecicki wrote:
> > Stopping tasks: 
> > ==================================================================
> >  stopping tasks failed (2 tasks remaining)
> > Restarting tasks...<6> Strange, katad-1 not stopped
> >  Strange, katad-2 not stopped
> >  done
> 
> 
> Both Pavel Machek and I posted test patches to address this... 
> basically, because of the design of swsusp, you must copy-n-paste the 
> following code into every single kernel thread:
> 
>                          if (current->flags & PF_FREEZE)
>                                  refrigerator(PF_IOTHREAD);
> 
> But I consider suspend untested at best... for reboot and suspend the 
> driver should issue flush-cache and other things beyond simply freezing 
> the kernel thread.  Further, suspending will suck if the kernel thread 
> itself is the one doing I/O on behalf of the driver.  This occurs if the 
> transfer mode is PIO rather than DMA.
> 
> 	Jeff
> 
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-- 
My work on Software Suspend is graciously brought to you by
LinuxFund.org.


      reply	other threads:[~2003-12-15 18:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-15 15:00 Suspend not working with SATA: Witold Krecicki
2003-12-15 15:18 ` Jeff Garzik
2003-12-15 18:22   ` Nigel Cunningham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1071512548.14229.88.camel@laptop-linux \
    --to=ncunningham@clear.net.nz \
    --cc=adasi@kernel.pl \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox