From: Michael Hunold <hunold@linuxtv.org>
To: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 11/12] Firmware_class update
Date: Fri, 19 Dec 2003 13:28:45 +0100 [thread overview]
Message-ID: <1071836925779@convergence.de> (raw)
In-Reply-To: <10718369253490@convergence.de>
- use a kernel thread instead of schedule_work() when waiting for the firmware upload to happen
--- linux-2.5/drivers/base/firmware_class.c (revision 14117)
+++ linux-2.5/drivers/base/firmware_class.c (working copy)
@@ -415,18 +415,22 @@
void (*cont)(const struct firmware *fw, void *context);
};
-static void
+static int
request_firmware_work_func(void *arg)
{
struct firmware_work *fw_work = arg;
const struct firmware *fw;
- if (!arg)
- return;
+ if (!arg) {
+ WARN_ON(1);
+ return 0;
+ }
+ daemonize("%s/%s", "firmware", fw_work->name);
request_firmware(&fw, fw_work->name, fw_work->device);
fw_work->cont(fw, fw_work->context);
release_firmware(fw);
module_put(fw_work->module);
kfree(fw_work);
+ return 0;
}
/**
@@ -451,6 +455,8 @@
{
struct firmware_work *fw_work = kmalloc(sizeof (struct firmware_work),
GFP_ATOMIC);
+ int ret;
+
if (!fw_work)
return -ENOMEM;
if (!try_module_get(module)) {
@@ -465,9 +471,14 @@
.context = context,
.cont = cont,
};
- INIT_WORK(&fw_work->work, request_firmware_work_func, fw_work);
- schedule_work(&fw_work->work);
+ ret = kernel_thread(request_firmware_work_func, fw_work,
+ CLONE_FS | CLONE_FILES);
+
+ if (ret < 0) {
+ fw_work->cont(NULL, fw_work->context);
+ return ret;
+ }
return 0;
}
next prev parent reply other threads:[~2003-12-19 12:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-19 12:28 [PATCH 0/12] LinuxTV.org DVB+V4L fixes Michael Hunold
2003-12-19 12:28 ` [PATCH 1/12] Remove firmware of av7110 driver Michael Hunold
2003-12-19 12:28 ` [PATCH 2/12] Update saa7146 capture core Michael Hunold
2003-12-19 12:28 ` [PATCH 3/12] Add new DVB driver Michael Hunold
2003-12-19 12:28 ` [PATCH 4/12] Update Skystar2 " Michael Hunold
2003-12-19 12:28 ` [PATCH 5/12] Update DVB core Michael Hunold
2003-12-19 12:28 ` [PATCH 6/12] Update DVB frontend drivers Michael Hunold
2003-12-19 12:28 ` [PATCH 7/12] Update av7110 driver Michael Hunold
2003-12-19 12:28 ` [PATCH 8/12] Add firmware loading support to " Michael Hunold
2003-12-19 12:28 ` [PATCH 9/12] Update TTUSB DEC driver Michael Hunold
2003-12-19 12:28 ` [PATCH 10/12] Cleanup patch to remove 2.4 crud Michael Hunold
2003-12-19 12:28 ` Michael Hunold [this message]
2003-12-19 12:28 ` [PATCH 12/12] Add DVB documentation Michael Hunold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1071836925779@convergence.de \
--to=hunold@linuxtv.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox