public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Love <rml@ximian.com>
To: Joe Korty <joe.korty@ccur.com>
Cc: William Lee Irwin III <wli@holomorphy.com>,
	Albert Cahalan <albert@users.sourceforge.net>,
	linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: atomic copy_from_user?
Date: Mon, 22 Dec 2003 17:14:48 -0500	[thread overview]
Message-ID: <1072131288.3318.48.camel@fur> (raw)
In-Reply-To: <20031222215933.GA3189@rudolph.ccur.com>

On Mon, 2003-12-22 at 16:59, Joe Korty wrote:

>  I do not see why a non-preempt kernel would care at all about
> the value of preempt_count.  (kmap_atomic is obviously setting it,
> where is the place in a non-preempt kernel where the set value
> is being acted upon?).

Last I checked, the architecture-specific page fault handlers.  They do
something like:

	if (in_atomic())
		goto do_not_service_fault;

This let us implement the atomic copy_*_user() functions.

kmap_atomic() needs to mark the system atomic, so the in_atomic() will
fail.

This was done around ~2.5.30 by akpm.

	Rob Love



  reply	other threads:[~2003-12-22 22:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-22  0:48 atomic copy_from_user? Albert Cahalan
2003-12-22  4:31 ` Linus Torvalds
2003-12-22  9:36   ` Andrew Morton
2003-12-22 15:00 ` William Lee Irwin III
2003-12-22 18:26   ` Joe Korty
2003-12-22 20:55     ` Rob Love
2003-12-22 21:22       ` Joe Korty
2003-12-22 21:40         ` Rob Love
2003-12-22 21:59           ` Joe Korty
2003-12-22 22:14             ` Rob Love [this message]
2003-12-22 22:24             ` Andrew Morton
2003-12-22 22:06       ` Joe Korty
2003-12-22 22:18         ` Rob Love
2003-12-22 22:14       ` Andrew Morton
2003-12-22 22:19         ` Rob Love
2003-12-22 22:35           ` Joe Korty
2003-12-22 22:59             ` Rob Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1072131288.3318.48.camel@fur \
    --to=rml@ximian.com \
    --cc=albert@users.sourceforge.net \
    --cc=joe.korty@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox