From: Evgeniy Polyakov <zbr@ioremap.net>
To: Vignesh R <vigneshr@ti.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jonathan Corbet <corbet@lwn.net>
Cc: Tony Lindgren <tony@atomide.com>, NeilBrown <neilb@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fabian Frederick <fabf@skynet.be>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode
Date: Thu, 11 Jun 2015 18:34:34 +0300 [thread overview]
Message-ID: <1072261434036874@web13o.yandex.ru> (raw)
In-Reply-To: <5562AFDB.1080701@ti.com>
Hi
25.05.2015, 08:15, "Vignesh R" <vigneshr@ti.com>:
>> HDQ mode remains unchanged.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
I have no experience with omap_hdq platform, but there are quite a few questions
related to IO - you never check whether write was successful or read returned actually
valid data, is it ok? I mean is it correct to assume that read can not return 0xff for example
and it is a sign that something is wrong, or this can not happen?
As for me, I have no objection, but this patch must go via omap tree imo.
next prev parent reply other threads:[~2015-06-11 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 12:09 [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode Vignesh R
2015-05-25 5:15 ` Vignesh R
2015-06-11 15:34 ` Evgeniy Polyakov [this message]
2015-06-12 5:23 ` Vignesh R
2015-05-28 21:27 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1072261434036874@web13o.yandex.ru \
--to=zbr@ioremap.net \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=fabf@skynet.be \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=neilb@suse.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox