From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Problem with dev_kfree_skb_any() in 2.6.0
Date: Sun, 28 Dec 2003 10:17:34 +1100 [thread overview]
Message-ID: <1072567054.4112.14.camel@gaston> (raw)
I'm getting Ooops reports with sungem. The problem is that in the PM
code (and possibly other exceptional code path), it will clean the rings
at non interrupt time but with a spinlock_irq held.
it uses dev_kfree_skb_any() which does:
static inline void dev_kfree_skb_any(struct sk_buff *skb)
{
if (in_irq())
dev_kfree_skb_irq(skb);
else
dev_kfree_skb(skb);
}
However, in_irq() seem to only catch real IRQ time, so I end up calling
dev_kfree_skb(), which triggers the following BUG() in local_bh_enable()
WARN_ON(irqs_disabled());
We should probably fix dev_kfree_skb_any() ? Still ugly imho though...
- if (in_irq())
+ if (in_irq() || irqs_disabled())
Ben.
next reply other threads:[~2003-12-27 23:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-27 23:17 Benjamin Herrenschmidt [this message]
2003-12-28 1:07 ` Problem with dev_kfree_skb_any() in 2.6.0 David S. Miller
2003-12-28 5:44 ` Benjamin Herrenschmidt
2003-12-30 4:09 ` Jeff Garzik
2003-12-30 4:51 ` David S. Miller
2003-12-30 5:15 ` Jeff Garzik
2003-12-30 6:01 ` David S. Miller
2003-12-30 6:12 ` Jeff Garzik
2003-12-30 6:13 ` David S. Miller
2003-12-30 17:43 ` Jeff Garzik
2004-01-01 20:42 ` David S. Miller
2004-01-02 2:58 ` Jeff Garzik
2004-01-06 3:54 ` David S. Miller
2003-12-30 6:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1072567054.4112.14.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox