From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "David S. Miller" <davem@redhat.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Problem with dev_kfree_skb_any() in 2.6.0
Date: Sun, 28 Dec 2003 16:44:29 +1100 [thread overview]
Message-ID: <1072590269.741.7.camel@gaston> (raw)
In-Reply-To: <20031227170755.4990419b.davem@redhat.com>
On Sun, 2003-12-28 at 12:07, David S. Miller wrote:
> On Sun, 28 Dec 2003 10:17:34 +1100
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > We should probably fix dev_kfree_skb_any() ? Still ugly imho though...
> >
> > - if (in_irq())
> > + if (in_irq() || irqs_disabled())
> >
>
> That's not the right fix, the sungem PM code path TX queue
> packet freeing should be instead done outside of IRQ spinlocks.
>
> .../...
The "workaround" is a bit complicated, but I'll look into it,
I could probably get the whole clean ring thing out of the
spinlock instead (I need to reduce time spent in those locks
anyway).
Though it's really inconsistent imho, to have that routine that
can be called at task time, interrupt time, but not task time with
a spinlock held... especially since it's called *kfree*, I would
have expected kfree-like semantics...
Note that among the drivers broken with that same bug (typically
in the close() path) are :
- sunhme
- b44
- tg3
- ...
Almost all drivers calling dev_kfree_skb_any() do that within a
spinlock_irq ...
Ben.
next prev parent reply other threads:[~2003-12-28 5:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-27 23:17 Problem with dev_kfree_skb_any() in 2.6.0 Benjamin Herrenschmidt
2003-12-28 1:07 ` David S. Miller
2003-12-28 5:44 ` Benjamin Herrenschmidt [this message]
2003-12-30 4:09 ` Jeff Garzik
2003-12-30 4:51 ` David S. Miller
2003-12-30 5:15 ` Jeff Garzik
2003-12-30 6:01 ` David S. Miller
2003-12-30 6:12 ` Jeff Garzik
2003-12-30 6:13 ` David S. Miller
2003-12-30 17:43 ` Jeff Garzik
2004-01-01 20:42 ` David S. Miller
2004-01-02 2:58 ` Jeff Garzik
2004-01-06 3:54 ` David S. Miller
2003-12-30 6:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1072590269.741.7.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox