public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Love <rml@ximian.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	Daniel Tram Lux <daniel@starbattle.com>,
	steve@drifthost.com, James Bourne <jbourne@hardrock.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Gergely Tamas <dice@mfa.kfki.hu>,
	Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Subject: Re: no DRQ after issuing WRITE was Re: 2.4.23-uv3 patch set released
Date: Tue, 30 Dec 2003 17:23:35 -0500	[thread overview]
Message-ID: <1072823015.4350.40.camel@fur> (raw)
In-Reply-To: <Pine.LNX.4.58.0312301352570.2065@home.osdl.org>

On Tue, 2003-12-30 at 16:57, Linus Torvalds wrote:

> Is CONFIG_PREEMPT on in the cases, and is there really no locking 
> anywhere? Preempting in the middle of the data transfer phase sounds like 
> a fundamentally bad idea, and maybe the code needs a few preempt 
> disable/enable pairs somewhere?

Is the kernel patched with kernel preemption?  It is not in stock 2.4.

Anyhow, if interrupts are disabled, preemption should be disabled (we
check for that condition in both preempt_schedule() and
return_from_intr).

If interrupts are not disabled, then preempting would definitely be a
bad thing.  But I would think, for the same reasons you do not want to
preempt, you would want interrupts disabled ..

	Rob Love



  parent reply	other threads:[~2003-12-30 22:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-29  7:58 2.4.23-uv3 patch set released James Bourne
2003-12-30 11:36 ` Marcelo Tosatti
2003-12-30 19:59   ` Linus Torvalds
2003-12-30 21:46     ` no DRQ after issuing WRITE was " Marcelo Tosatti
2003-12-30 21:57       ` Linus Torvalds
2003-12-30 22:21         ` Marcelo Tosatti
2003-12-30 23:18           ` Eric D. Mudama
2003-12-30 22:23         ` Rob Love [this message]
2003-12-30 22:54           ` Linus Torvalds
2003-12-30 22:58             ` Rob Love
2004-01-03 11:22               ` Daniel Tram Lux
2004-01-03 18:57                 ` Linus Torvalds
2004-01-03 19:27                   ` Daniel Tram Lux
2004-01-03 22:10     ` Pavel Machek
2003-12-31  6:10   ` James Bourne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1072823015.4350.40.camel@fur \
    --to=rml@ximian.com \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=daniel@starbattle.com \
    --cc=dice@mfa.kfki.hu \
    --cc=jbourne@hardrock.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=steve@drifthost.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox