public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Karol Kozimor <sziwan@hell.org.pl>, Andrew Morton <akpm@osdl.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Arjan van de Ven <arjanv@redhat.com>, jw schultz <jw@pegasys.ws>
Subject: Re: [2.6.0-mm2] PM timer still has problems
Date: Tue, 06 Jan 2004 00:31:18 -0800	[thread overview]
Message-ID: <1073377877.2752.38.camel@localhost> (raw)
In-Reply-To: <200401050117.06681.dtor_core@ameritech.net>

On Sun, 2004-01-04 at 22:17, Dmitry Torokhov wrote:
> I decided to go hpet way and use tsc in ACPI PM timer to do delay stuff
> and monotonic clock. 

I think you have a valid point that as loops_per_jiffy isn't updated,
delay_pmtmr() and delay_pit() are broken w/ CPUFREQ.  

However I don't understand using the TSC for montonic_clock. I have no
clue why the HPET folks implemented it that way (likely my fault for not
enough documentaiton), but I haven't had the time to try to clean up
that code. And really, if your TSC is reliable enough for
monotonic_clock, why are you using the pmtmr? :) Unless it specifically
is resolving an issue, I'd drop that change. 

> Plus there some code rearrangements, and stuff I grabbed
> from the CPUFREQ list (Dominics + Li Shahoua P4 variable tsc info ), etc...
> If there is an interest I can split the code into smaller chinks. 

Yes. Please do split out the white space, and the cpufreq changes as
well. I realize that the patch is very inter-woven, but atleast those
two changes are fairly seperable. 

> For what
> it worth I am running with ACPI PM timer, CPUFREQ (dynamically switching
> frequency based on load) and Synaptics and everything is calm. Ntpd has also
> stopped complaining about loosing sync...

Its very good this is working for you! However, I'd definately like to
narrow down the specific change that causes it to work.

thanks for the strong interest and effort!
-john


  parent reply	other threads:[~2004-01-06  8:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-30 20:48 [2.6.0-mm2] PM timer still has problems Karol Kozimor
2003-12-31  4:02 ` Andrew Morton
2004-01-04  0:44   ` Karol Kozimor
2004-01-05  6:17     ` Dmitry Torokhov
2004-01-05 12:18       ` Karol Kozimor
2004-01-06  8:31       ` john stultz [this message]
2004-01-07  6:30         ` Dmitry Torokhov
2004-01-07 17:01           ` john stultz
2004-03-29 15:44       ` Karol Kozimor
2004-01-05 22:11 ` john stultz
2004-01-05 22:17   ` Karol Kozimor
2004-01-05 22:32     ` john stultz
2004-01-05 22:54       ` Karol Kozimor
2004-01-05 23:18       ` Karol Kozimor
2004-01-05 23:30         ` john stultz
2004-01-06  4:32   ` Dmitry Torokhov
2004-01-17  1:54     ` Karol Kozimor
2004-01-24  0:55     ` Karol Kozimor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1073377877.2752.38.camel@localhost \
    --to=johnstul@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=arjanv@redhat.com \
    --cc=dtor_core@ameritech.net \
    --cc=jw@pegasys.ws \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sziwan@hell.org.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox