From: James Bottomley <James.Bottomley@steeleye.com>
To: Andrew Morton <akpm@osdl.org>
Cc: johnstul@us.ibm.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix get_jiffies_64 to work on voyager
Date: 06 Jan 2004 12:53:10 -0600 [thread overview]
Message-ID: <1073415191.2047.63.camel@mulgrave> (raw)
In-Reply-To: <20040106090521.4a7ad2a0.akpm@osdl.org>
On Tue, 2004-01-06 at 11:05, Andrew Morton wrote:
> No, it was much simpler in my case: log_buf_len_setup() was accidentally
> enabling interrupts early in boot and we were taking a timer interrupt
> while holding a write lock on xtime_lock. sched_clock() was requiring a
> read lock and boom.
Voyager has no APIC local timer equivalent, so I rebroadcast the timer
tick to all CPUs. However, the local tick is done in this thread with
the xtime_lock held as write and it can trigger the scheduler load
balancing, which needs to call sched_clock()....boom.
All in all, this does show that the xtime sequence lock is a bit too
fragile. It also seems to show that we should redo the subarch timer
hooks if we want to make the sequence locks work.
I think there should be two hooks: one called holding the xtime write
lock for doing clock adjustment specific things and the other called
after we've released the xtime write lock.
James
next prev parent reply other threads:[~2004-01-06 18:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-06 16:04 [PATCH] fix get_jiffies_64 to work on voyager James Bottomley
2004-01-06 16:19 ` Andrew Morton
2004-01-06 16:26 ` James Bottomley
2004-01-06 17:05 ` Andrew Morton
2004-01-06 18:53 ` James Bottomley [this message]
2004-01-06 16:29 ` Linus Torvalds
2004-01-06 17:05 ` Andrew Morton
2004-01-06 17:11 ` Tim Schmielau
2004-01-06 17:22 ` Andrew Morton
2004-01-06 17:37 ` Tim Schmielau
2004-01-06 18:02 ` Linus Torvalds
2004-01-06 16:30 ` Tim Schmielau
2004-01-06 16:26 ` Linus Torvalds
2004-01-06 18:29 ` Paulo Marques
2004-01-06 18:46 ` Linus Torvalds
2004-01-06 19:04 ` Paulo Marques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1073415191.2047.63.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox