public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: ncunningham@users.sourceforge.net
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: Fix support for wide consoles in vt.c and include/linux/selection.h
Date: Fri, 09 Jan 2004 16:29:03 +1100	[thread overview]
Message-ID: <1073626143.828.2.camel@gaston> (raw)
In-Reply-To: <1073621988.2003.40.camel@laptop-linux>

On Fri, 2004-01-09 at 15:19, Nigel Cunningham wrote:
> Hi.
> 
> In implementing a 'nice' display for Software Suspend, some users with
> wide VTs reported problems with distortion. These changes from signed to
> unsigned int/char fixed the issue and have been tested for around a year
> (guesstimate).
> 
> The only other user of getconsxy is vc_screen.c. It might benefit from
> matching changes, although the users who reported the problem to me said
> nothing about other issues with their displays, so far as I recall.
> 
> To actually use the functions from Suspend, the functions also had to be
> made non-static. Of course I could make this into 2 patches if desired.

Also make sure you grab the console semaphore when doing those things,
or recent 2.6's (at least -mm) will probably bark on you :)

Ben.


      reply	other threads:[~2004-01-09  5:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-09  4:19 PATCH: Fix support for wide consoles in vt.c and include/linux/selection.h Nigel Cunningham
2004-01-09  5:29 ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1073626143.828.2.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox