From: Xavier Bestel <xavier.bestel@free.fr>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.0: blkdev_get() oopses on floppy
Date: Mon, 12 Jan 2004 09:16:00 +0100 [thread overview]
Message-ID: <1073895358.950.38.camel@nomade> (raw)
In-Reply-To: <1073894153.950.19.camel@nomade>
Le lun 12/01/2004 à 08:55, Xavier Bestel a écrit :
> > *NOTE*: unless you are really forced to, don't use that "open by device
> > number" crap at all - normal filp_open() will do nicely if you have the
> > pathname of device in question and it's _much_ better interface.
>
> But that's exactely what raw.c does (although the userspace knows the
> dev pathname).
Aye, userspace doesn't always know it, and the ioctl for /dev/rawctl
only uses major:minor.
That's too bad, because raw.c is one of the few users of blkdev_get() in
the kernel (the others being drivers/s390/block/dasd_genhd.c,
partitions/check.c and fs/block_dev.c itself). Could have got rid of
this crap :)
Xav
prev parent reply other threads:[~2004-01-12 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-11 22:50 2.6.0: blkdev_get() oopses on floppy Xavier Bestel
2004-01-12 1:52 ` viro
2004-01-12 7:55 ` Xavier Bestel
2004-01-12 8:16 ` Xavier Bestel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1073895358.950.38.camel@nomade \
--to=xavier.bestel@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox