From: James Bottomley <James.Bottomley@steeleye.com>
To: James Cleverdon <jamesclv@us.ibm.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.6.1-mm2: Get irq_vector size right for generic subarch UP installer kernels
Date: 14 Jan 2004 14:34:45 -0500 [thread overview]
Message-ID: <1074108886.11035.59.camel@mulgrave> (raw)
I don't think this:
+# if defined(CONFIG_X86_SUMMIT) || defined(CONFIG_X86_GENERICARCH)
Is a good idea. You're contaminating the default subarch with another
subarch specific #define.
generic arch additions are fine here, but you should find a better way
to abstract the summit stuff.
James
next reply other threads:[~2004-01-14 19:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-14 19:34 James Bottomley [this message]
2004-01-14 20:01 ` [PATCH] 2.6.1-mm2: Get irq_vector size right for generic subarch UP installer kernels James Cleverdon
2004-01-14 21:49 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2004-01-16 2:35 Nakajima, Jun
2004-01-18 19:06 ` Zwane Mwaikambo
2004-01-14 23:13 Nakajima, Jun
2004-01-15 4:36 ` Zwane Mwaikambo
2004-01-15 21:57 ` James Cleverdon
2004-01-15 22:40 ` Zwane Mwaikambo
2004-01-16 5:45 ` William Lee Irwin III
2004-01-15 22:42 ` Mika Penttilä
2004-01-14 21:50 Nakajima, Jun
2004-01-14 22:20 ` Zwane Mwaikambo
2004-01-14 0:26 James Cleverdon
2004-01-14 1:00 ` Zwane Mwaikambo
2004-01-14 19:59 ` James Cleverdon
2004-01-14 22:22 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1074108886.11035.59.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=jamesclv@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox