From: "Yury V. Umanets" <umka@namesys.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Tim Cambrant <tim@cambrant.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Newbie-warning] MOD_INC_USE_COUNT usage
Date: Thu, 15 Jan 2004 16:53:37 +0300 [thread overview]
Message-ID: <1074174817.1837.151.camel@firefly> (raw)
In-Reply-To: <m37jzuv14v.fsf@defiant.pm.waw.pl>
On Wed, 2004-01-14 at 21:25, Krzysztof Halasa wrote:
> Tim Cambrant <tim@cambrant.com> writes:
>
> > So, why shouldn't this patch be applied?:
> >
> > --- drivers/ide/pci/generic.c.orig 2004-01-14 17:52:35.000000000 +0100
> > +++ drivers/ide/pci/generic.c 2003-11-24 13:54:01.000000000 +0100
> > @@ -121,6 +121,7 @@ static int __devinit generic_init_one(st
> > return 1;
> > }
> > ide_setup_pci_device(dev, d);
> > + MOD_INC_USE_COUNT;
> > return 0;
> > }
>
> It isn't that easy - the module must be marked as being in use this
> way or (preferably) another.
Hello,
As I can see, this is really redundant to have a MOD_INC_USE_COUNT for
almost all the modules. But this should be checked carefully before
removing ;)
--
umka
prev parent reply other threads:[~2004-01-15 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-14 17:20 [Newbie-warning] MOD_INC_USE_COUNT usage Tim Cambrant
2004-01-14 18:25 ` Krzysztof Halasa
2004-01-15 13:53 ` Yury V. Umanets [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1074174817.1837.151.camel@firefly \
--to=umka@namesys.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@cambrant.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox