Re: Problem with CONFIG_SYSCTL disabled

[Marcel Holtmann <marcel@holtmann.org>]

Hi,

> > 	In file included from drivers/net/net_init.c:53:
> > 	include/net/neighbour.h:216: error: parse error before "proc_handler"
> > 	include/net/neighbour.h:216: warning: function declaration isn't a prototype
> 
> ===== include/net/neighbour.h 1.5 vs edited =====
> --- 1.5/include/net/neighbour.h	Thu Jan 15 17:58:09 2004
> +++ edited/include/net/neighbour.h	Mon Jan 19 22:42:24 2004
> @@ -47,9 +47,7 @@
>  #include <linux/skbuff.h>
>  
>  #include <linux/err.h>
> -#ifdef CONFIG_SYSCTL
>  #include <linux/sysctl.h>
> -#endif
>  
>  #define NUD_IN_TIMER	(NUD_INCOMPLETE|NUD_DELAY|NUD_PROBE)
>  #define NUD_VALID	(NUD_PERMANENT|NUD_NOARP|NUD_REACHABLE|NUD_PROBE|NUD_STALE|NUD_DELAY)

so it is not needed to wrap the inclusion of linux/sysctl.h around
#ifdef's, but why is it done so many times?

	net/core/neighbour.c
	net/ipv4/devinet.c
	net/ipv4/arp.c
	net/ipv4/route.c
	net/ipv4/netfilter/ip_conntrack_standalone.c
	net/ipv6/route.c
	net/ipv6/addrconf.c
	net/ipv6/ndisc.c
	net/ipv6/icmp.c
	net/appletalk/sysctl_net_atalk.c
	net/bridge/br_netfilter.c

Regards

Marcel