public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] i2c driver fixes for 2.6.1
Date: Mon, 19 Jan 2004 15:59:17 -0800	[thread overview]
Message-ID: <1074556757661@kroah.com> (raw)
In-Reply-To: <10745567571488@kroah.com>

ChangeSet 1.1474.98.2, 2004/01/14 11:09:15-08:00, khali@linux-fr.org

[PATCH] I2C: documentation update

> > They should be converted.  From module.h:
> > 	/* DEPRECATED: Do not use. */
> > 	#define MODULE_PARM(var,type) 	\
> > 	...
>
> Note that realistically, it's not going away in 2.6, so mass migration
> doesn't really win anything.  However, I never implemented mixing old
> and new style in the same module, so if you're adding a parameter, it
> makes sense to convert them all.

OK, I don't have much time for a mass conversion anyway. Greg, could you
please apply the following patch to the "porting-clients" document so
that at least the new drivers don't need to be converted afterwards?


 Documentation/i2c/porting-clients |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletion(-)


diff -Nru a/Documentation/i2c/porting-clients b/Documentation/i2c/porting-clients
--- a/Documentation/i2c/porting-clients	Mon Jan 19 15:33:17 2004
+++ b/Documentation/i2c/porting-clients	Mon Jan 19 15:33:17 2004
@@ -92,7 +92,10 @@
   i2c_get_clientdata(client) instead.
 
 * [Interface] Init function should not print anything. Make sure
-  there is a MODULE_LICENSE() line.
+  there is a MODULE_LICENSE() line. MODULE_PARM() is replaced
+  by module_param(). Note that module_param has a third parameter,
+  that you should set to 0 by default. See include/linux/moduleparam.h
+  for details.
 
 Coding policy:
 


  reply	other threads:[~2004-01-20  0:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-19 23:57 [BK PATCH] i2c driver fixes for 2.6.1 Greg KH
2004-01-19 23:59 ` [PATCH] " Greg KH
2004-01-19 23:59   ` Greg KH [this message]
2004-01-19 23:59     ` Greg KH
2004-01-19 23:59       ` Greg KH
2004-01-19 23:59         ` Greg KH
2004-01-19 23:59           ` Greg KH
2004-01-19 23:59             ` Greg KH
2004-01-19 23:59               ` Greg KH
2004-01-19 23:59                 ` Greg KH
2004-01-19 23:59                   ` Greg KH
2004-01-19 23:59                     ` Greg KH
2004-01-19 23:59                       ` Greg KH
2004-01-19 23:59                         ` Greg KH
2004-01-19 23:59                           ` Greg KH
2004-01-19 23:59                             ` Greg KH
2004-01-19 23:59                               ` Greg KH
2004-01-19 23:59                                 ` Greg KH
2004-01-19 23:59                                   ` Greg KH
2004-01-19 23:59                                     ` Greg KH
2004-01-19 23:59                                       ` Greg KH
2004-01-19 23:59                                         ` Greg KH
2004-01-19 23:59                                           ` Greg KH
2004-01-19 23:59                                             ` Greg KH
2004-01-19 23:59                                               ` Greg KH
2004-01-19 23:59                                                 ` Greg KH
2004-01-19 23:59                                                   ` Greg KH
2004-01-19 23:59                                                     ` Greg KH
2004-01-19 23:59                                                       ` Greg KH
2004-01-19 23:59                                                         ` Greg KH
2004-01-21 21:50                                                 ` Jean Delvare
2004-01-21 23:56                                                   ` Greg KH
2004-01-31  8:56                                                     ` Jean Delvare
2004-01-31 15:23                                                       ` Greg KH
2004-01-20 22:03     ` Jean Delvare
2004-01-20 22:07       ` Greg KH
2004-01-21 20:47         ` Jean Delvare
2004-01-24  1:14           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1074556757661@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox