From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] i2c driver fixes for 2.6.1
Date: Mon, 19 Jan 2004 15:59:25 -0800 [thread overview]
Message-ID: <10745567653686@kroah.com> (raw)
In-Reply-To: <10745567653998@kroah.com>
ChangeSet 1.1474.98.22, 2004/01/19 12:50:11-08:00, khali@linux-fr.org
[PATCH] I2C: Fix i2c busses warnings with DEBUG
Two bus drivers (i2c-via and scx200_acb.c) generate warnings when the
whole i2c subsystem is compiled with -DDEBUG. Suggested changes follow.
drivers/i2c/busses/i2c-via.c | 2 +-
drivers/i2c/busses/scx200_acb.c | 6 ++----
2 files changed, 3 insertions(+), 5 deletions(-)
diff -Nru a/drivers/i2c/busses/i2c-via.c b/drivers/i2c/busses/i2c-via.c
--- a/drivers/i2c/busses/i2c-via.c Mon Jan 19 15:29:00 2004
+++ b/drivers/i2c/busses/i2c-via.c Mon Jan 19 15:29:00 2004
@@ -21,7 +21,7 @@
Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
-#define DEBUG
+/* #define DEBUG */
#include <linux/kernel.h>
#include <linux/module.h>
diff -Nru a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
--- a/drivers/i2c/busses/scx200_acb.c Mon Jan 19 15:29:00 2004
+++ b/drivers/i2c/busses/scx200_acb.c Mon Jan 19 15:29:00 2004
@@ -47,9 +47,7 @@
MODULE_PARM(base, "1-4i");
MODULE_PARM_DESC(base, "Base addresses for the ACCESS.bus controllers");
-#define DEBUG 0
-
-#if DEBUG
+#ifdef DEBUG
#define DBG(x...) printk(KERN_DEBUG NAME ": " x)
#else
#define DBG(x...)
@@ -374,7 +372,7 @@
if (rc == 0 && size == I2C_SMBUS_WORD_DATA && rw == I2C_SMBUS_READ)
data->word = le16_to_cpu(cur_word);
-#if DEBUG
+#ifdef DEBUG
printk(KERN_DEBUG NAME ": transfer done, result: %d", rc);
if (buffer) {
int i;
next prev parent reply other threads:[~2004-01-20 2:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-19 23:57 [BK PATCH] i2c driver fixes for 2.6.1 Greg KH
2004-01-19 23:59 ` [PATCH] " Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH [this message]
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-19 23:59 ` Greg KH
2004-01-21 21:50 ` Jean Delvare
2004-01-21 23:56 ` Greg KH
2004-01-31 8:56 ` Jean Delvare
2004-01-31 15:23 ` Greg KH
2004-01-20 22:03 ` Jean Delvare
2004-01-20 22:07 ` Greg KH
2004-01-21 20:47 ` Jean Delvare
2004-01-24 1:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10745567653686@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox