From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: davej@redhat.com
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: logic error in radeonfb.
Date: Fri, 23 Jan 2004 17:46:35 +1100 [thread overview]
Message-ID: <1074840394.949.200.camel@gaston> (raw)
In-Reply-To: <E1Ajuub-0000xr-00@hardwired>
On Fri, 2004-01-23 at 17:35, davej@redhat.com wrote:
> Looks like another instance of a ! in the wrong place.
Ohh, and _oooold_ bug fixed a long time ago in 2.4. There may actually
be another occurence of this one elsewhere iirc. I'll check that. Note
that this code is powermac specific anyway and that old radeonfb doesn't
work very well on a lot of powermacs, so it's not very urgent. The new
radeonfb which has that fixed for a long time will get in along with
the fbdev updates as soon as I'm finished cleaning them up.
Ben.
> Dave
>
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/video/radeonfb.c linux-2.5/drivers/video/radeonfb.c
> --- bk-linus/drivers/video/radeonfb.c 2004-01-21 15:58:42.000000000 +0000
> +++ linux-2.5/drivers/video/radeonfb.c 2004-01-21 17:48:54.000000000 +0000
> @@ -2319,7 +2319,7 @@ static int radeon_set_backlight_enable(i
> lvds_gen_cntl |= (LVDS_BL_MOD_EN | LVDS_BLON);
> if (on && (level > BACKLIGHT_OFF)) {
> lvds_gen_cntl |= LVDS_DIGON;
> - if (!lvds_gen_cntl & LVDS_ON) {
> + if (!(lvds_gen_cntl & LVDS_ON)) {
> lvds_gen_cntl &= ~LVDS_BLON;
> OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);
> (void)INREG(LVDS_GEN_CNTL);
--
Benjamin Herrenschmidt <benh@kernel.crashing.org>
next prev parent reply other threads:[~2004-01-23 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 6:35 logic error in radeonfb davej
2004-01-23 6:46 ` Benjamin Herrenschmidt [this message]
2004-01-23 6:54 ` Dave Jones
2004-01-23 7:03 ` Benjamin Herrenschmidt
2004-01-23 11:24 ` John Levon
2004-01-23 13:53 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1074840394.949.200.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox