[PATCH 2.0.39] put_last_free() defined, but not used

[PATCH 2.0.39] put_last_free() defined, but not used

[Coywolf Qi Hunt]

Hello,

In 2.0.39, the function put_last_free() in fs/file_table.c is defined, 
but no longer get used.
Should it be removed?

thanks


--- fs/file_table.c.orig    1994-10-21 07:39:36.000000000 +0800
+++ fs/file_table.c    2004-01-26 03:10:38.000000000 +0800
@@ -52,20 +52,6 @@
     prev->f_next = next;
 }
 
-/*
- * Insert a file structure at the end of the list of available ones.
- */
-static inline void put_last_free(struct file *file)
-{
-    struct file *next, *prev;
-
-    next = first_file;
-    file->f_next = next;
-    prev = next->f_prev;
-    next->f_prev = file;
-    file->f_prev = prev;
-    prev->f_next = file;
-}
 
 /*
  * Allocate a new memory page for file structures and

Re: [PATCH 2.0.39] put_last_free() defined, but not used

[David Weinehall]

On Mon, Jan 26, 2004 at 03:23:15AM +0800, Coywolf Qi Hunt wrote:
> Hello,
> 
> In 2.0.39, the function put_last_free() in fs/file_table.c is defined, 
> but no longer get used.
> Should it be removed?

I might consider this for 2.0.41, not for 2.0.40.  Indeed it doesn't
seem to be used, but it might be used in some external file system.


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/

Re: [PATCH 2.0.39] put_last_free() defined, but not used

[Jens Axboe]

On Sun, Jan 25 2004, David Weinehall wrote:
> On Mon, Jan 26, 2004 at 03:23:15AM +0800, Coywolf Qi Hunt wrote:
> > Hello,
> > 
> > In 2.0.39, the function put_last_free() in fs/file_table.c is defined, 
> > but no longer get used.
> > Should it be removed?
> 
> I might consider this for 2.0.41, not for 2.0.40.  Indeed it doesn't
> seem to be used, but it might be used in some external file system.

The function was static.

-- 
Jens Axboe

Re: [PATCH 2.0.39] put_last_free() defined, but not used

[David Weinehall]

On Mon, Jan 26, 2004 at 12:43:48AM +0100, Jens Axboe wrote:
> On Sun, Jan 25 2004, David Weinehall wrote:
> > On Mon, Jan 26, 2004 at 03:23:15AM +0800, Coywolf Qi Hunt wrote:
> > > Hello,
> > > 
> > > In 2.0.39, the function put_last_free() in fs/file_table.c is defined, 
> > > but no longer get used.
> > > Should it be removed?
> > 
> > I might consider this for 2.0.41, not for 2.0.40.  Indeed it doesn't
> > seem to be used, but it might be used in some external file system.
> 
> The function was static.

Ohhh, failed to spot that.  Bummer, since I just uploaded 2.0.40-rc8.
Then again, with the quality my -rc's have been of lately, there will
probably be a 2.0.40-rc9 anyway.  Sigh.


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/

[2.0.40-rc8] Works well

[Markus Hästbacka]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Hey David,
I just mail to tell you that 2.0.40-rc8 seems to work really well, no
problems compiling (except a few warnings :) and absolutely no problem
running. Great work!
 
	Markus

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [2.0.40-rc8] Works well

[David Weinehall]

On Tue, Jan 27, 2004 at 07:10:56PM +0200, Markus Hästbacka wrote:
> Hey David,
> I just mail to tell you that 2.0.40-rc8 seems to work really well, no
> problems compiling (except a few warnings :) and absolutely no problem
> running. Great work!

Most of the compile-time warning I got was from using a newer binutils,
but I'll try to fix all warnings (that are fixable without causing bugs)
in 2.0.41.


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/

Re: [2.0.40-rc8] Works well

[Coywolf Qi Hunt]

Markus Hästbacka wrote:

>Hey David,
>I just mail to tell you that 2.0.40-rc8 seems to work really well, no
>problems compiling (except a few warnings :) and absolutely no problem
>running. Great work!
> 
>	Markus
>  
>
Hello all 2.0 hackers,

Recently I just have such an idea that is to port the 2.0.39 to let it 
be compiled with my gcc 2.95.4 or any
other latest gcc. At the same time,  also make it remain compliant to 
gcc 2.7.2.1. ( I can't find 2.7.2.1, only 2.7.2.3
on the ftp)  Is this work worth while?

                Coywolf

Re: [2.0.40-rc8] Works well

[David Weinehall]

On Wed, Jan 28, 2004 at 03:28:30AM +0000, Coywolf Qi Hunt wrote:
> Markus Hästbacka wrote:
> 
> >Hey David,
> >I just mail to tell you that 2.0.40-rc8 seems to work really well, no
> >problems compiling (except a few warnings :) and absolutely no problem
> >running. Great work!
> >
> >	Markus
> > 
> >
> Hello all 2.0 hackers,

There aren't a lot, I suspect you can count us using one hand
nowadays...

> Recently I just have such an idea that is to port the 2.0.39 to let it 
> be compiled with my gcc 2.95.4 or any
> other latest gcc. At the same time,  also make it remain compliant to 
> gcc 2.7.2.1. ( I can't find 2.7.2.1, only 2.7.2.3
> on the ftp)  Is this work worth while?

Well, for sure it's quite a demanding task, since, if I remember
correctly, the module-code uses some nasty internal gcc-knowledge to
generate code, that simply doesn't work with later versions of gcc.
It might be that I remember this incorrectly though.

It would be interesting, yes, but only if it can be proved to some
degree that no new bugs are introduced.

My aim for 2.0.41 is to make it a cleanup-release; remove warnings, tidy
up a little source-code mess, kill dead code, fix typos etc.


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/

Re: [2.0.40-rc8] Works well

[Markus Hästbacka]

On Wed, 28 Jan 2004, David Weinehall wrote:

> On Wed, Jan 28, 2004 at 03:28:30AM +0000, Coywolf Qi Hunt wrote:
> ...
> > Recently I just have such an idea that is to port the 2.0.39 to let it
> > be compiled with my gcc 2.95.4 or any
> > other latest gcc. At the same time,  also make it remain compliant to
> > gcc 2.7.2.1. ( I can't find 2.7.2.1, only 2.7.2.3
> > on the ftp)  Is this work worth while?
>
> Well, for sure it's quite a demanding task, since, if I remember
> correctly, the module-code uses some nasty internal gcc-knowledge to
> generate code, that simply doesn't work with later versions of gcc.
> It might be that I remember this incorrectly though.
>
only the module-code? :)
> It would be interesting, yes, but only if it can be proved to some
> degree that no new bugs are introduced.
>
That would probably be impossible to do without introducing any bugs..
> My aim for 2.0.41 is to make it a cleanup-release; remove warnings, tidy
> up a little source-code mess, kill dead code, fix typos etc.
>
Sounds great, a bit amazing that 2.0 is alive again :)

	Markus

Re: [2.0.40-rc8] Works well

[David Weinehall]

On Wed, Jan 28, 2004 at 08:13:36AM +0200, Markus Hästbacka wrote:
> On Wed, 28 Jan 2004, David Weinehall wrote:
> 
> > On Wed, Jan 28, 2004 at 03:28:30AM +0000, Coywolf Qi Hunt wrote:
> > ...
> > > Recently I just have such an idea that is to port the 2.0.39 to let it
> > > be compiled with my gcc 2.95.4 or any
> > > other latest gcc. At the same time,  also make it remain compliant to
> > > gcc 2.7.2.1. ( I can't find 2.7.2.1, only 2.7.2.3
> > > on the ftp)  Is this work worth while?
> >
> > Well, for sure it's quite a demanding task, since, if I remember
> > correctly, the module-code uses some nasty internal gcc-knowledge to
> > generate code, that simply doesn't work with later versions of gcc.
> > It might be that I remember this incorrectly though.
> >
> only the module-code? :)

Well, I do remember that I did spend a few weeks getting the 2.0-tree to
compile with gcc-3.2, and most problems arose when dealing with the
module-code.  I think I gave up there.

> > It would be interesting, yes, but only if it can be proved to some
> > degree that no new bugs are introduced.
> >
> That would probably be impossible to do without introducing any bugs..

Mmmm.

> > My aim for 2.0.41 is to make it a cleanup-release; remove warnings, tidy
> > up a little source-code mess, kill dead code, fix typos etc.
> >
> Sounds great, a bit amazing that 2.0 is alive again :)

Oh, it's not been dead, as much as laying dormant.


Regards: David
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/

Re: [2.0.40-rc8] Works well

[Markus Hästbacka]

Btw - Are you going to announce the release of 2.0.40 (whenever it's
coming) or just put it on kernel.org?

	Markus

Re: [2.0.40-rc8] Works well

[David Weinehall]

On Thu, Jan 29, 2004 at 01:37:37AM +0200, Markus Hästbacka wrote:
> Btw - Are you going to announce the release of 2.0.40 (whenever it's
> coming) or just put it on kernel.org?

I will announce it.  It won't have any differences from 2.0.40-rc8
though (unless someone uncovers a flaw in -rc8 of course, which would
cause me to release an -rc9.)


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/

about 2.0 cleanup or adaption

[Coywolf Qi Hunt]

David Weinehall wrote:

> On Wed, Jan 28, 2004 at 03:28:30AM +0000, Coywolf Qi Hunt wrote:
> 
>>Recently I just have such an idea that is to port the 2.0.39 to let it 
>>be compiled with my gcc 2.95.4 or any
>>other latest gcc. At the same time,  also make it remain compliant to 
>>gcc 2.7.2.1. ( I can't find 2.7.2.1, only 2.7.2.3
>>on the ftp)  Is this work worth while?
> 
> 
> Well, for sure it's quite a demanding task, since, if I remember
> correctly, the module-code uses some nasty internal gcc-knowledge to
> generate code, that simply doesn't work with later versions of gcc.
> It might be that I remember this incorrectly though.

I think the first problem is to adapt the some inline assembly code to 
new style for the strict clobber list issue in recent gcc. If it is 
worthwhile, I'd like to do the work.

> 
> It would be interesting, yes, but only if it can be proved to some
> degree that no new bugs are introduced.
> 
> My aim for 2.0.41 is to make it a cleanup-release; remove warnings, tidy
> up a little source-code mess, kill dead code, fix typos etc.
> 
> 
> Regards: David Weinehall


I'm not sure of the defined but never used code. There's a lot.
How to deal with them?



	Coywolf

-- 
Coywolf Qi Hunt
Admin of http://GreatCN.org and http://LoveCN.org

[PATCH 2.0.40] Fix comment error of prepare_binprm() in exec.c

[Coywolf Qi Hunt]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

David Weinehall wrote:

> My aim for 2.0.41 is to make it a cleanup-release; remove warnings, tidy
> up a little source-code mess, kill dead code, fix typos etc.
> 
> 
> Regards: David Weinehall

Hello, David

In the comment of prepare_binprm() in fs/exec.c, 512 bytes should be 128 
bytes.

	Coywolf


-- 
Coywolf Qi Hunt
Admin of http://GreatCN.org and http://LoveCN.org

[-- Attachment #2: patch-cy0403030-2.0.40 --]
[-- Type: text/plain, Size: 364 bytes --]

--- linux-2.0.40/fs/exec.c	2004-02-27 11:48:20.000000000 +0800
+++ linux-2.0.40-cy/fs/exec.c	2004-03-03 21:14:28.000000000 +0800
@@ -528,7 +528,7 @@
 
 /* 
  * Fill the binprm structure from the inode. 
- * Check permissions, then read the first 512 bytes
+ * Check permissions, then read the first 128 bytes
  */
 int prepare_binprm(struct linux_binprm *bprm)
 {

Re: [PATCH 2.0.40] Fix comment error of prepare_binprm() in exec.c

[David Weinehall]

On Wed, Mar 03, 2004 at 09:38:09PM +0800, Coywolf Qi Hunt wrote:
> David Weinehall wrote:
> 
> >My aim for 2.0.41 is to make it a cleanup-release; remove warnings, tidy
> >up a little source-code mess, kill dead code, fix typos etc.
> >
> >
> >Regards: David Weinehall
> 
> Hello, David
> 
> In the comment of prepare_binprm() in fs/exec.c, 512 bytes should be 128 
> bytes.

Thanks.


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/