From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264894AbUBDXix (ORCPT ); Wed, 4 Feb 2004 18:38:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264365AbUBDXeh (ORCPT ); Wed, 4 Feb 2004 18:34:37 -0500 Received: from gate.crashing.org ([63.228.1.57]:56708 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S264566AbUBDXcv (ORCPT ); Wed, 4 Feb 2004 18:32:51 -0500 Subject: Re: fb.h header fix. From: Benjamin Herrenschmidt To: James Simmons Cc: Andrew Morton , torvalds@transmeta.com, Linux Kernel list , Linux Fbdev development list In-Reply-To: References: Content-Type: text/plain Message-Id: <1075937512.4029.47.camel@gaston> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Thu, 05 Feb 2004 10:31:53 +1100 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > Not yet, it's a ppc64 bug, I haven't had time to fix it, for some > > reason, ppc64 doesn't have readq/writeq nor __raw_ IO accessors. > > This means more than the fbdev layer will break on the ppc64. > Ben you you post a patch for the ppc64 so the fbdev patch can go in? Yes, but I think Andrew should still merge your patch at this point, I'll send the ppc64 fix today hopefully along with other ppc64 io.h fixes. Then we need the rest of the core & driver bits in. I'd really like 2.6.3 to be "complete" for PowerMacs (both ppc32 and ppc64) which means including the fbdev updates. I think the fbdev core changes are now good enough to get in. I'm fairly sure there are still fbcon bugs but I'm also sure those are already upstream so they aren't worth postponing the merge. Ben.