From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Greg KH <greg@kroah.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] PCI / OF linkage in sysfs
Date: Thu, 05 Feb 2004 11:13:14 +1100 [thread overview]
Message-ID: <1075939994.4371.58.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.58.0402041601080.2086@home.osdl.org>
On Thu, 2004-02-05 at 11:04, Linus Torvalds wrote:
> I think that I personally would be a lot happier with the situation if it
> wasn't that PCI had magic knowledge about OF in particular. In other
> words, you'd likely be able to sell me on an idea where the PCI layer just
> knows about "let the firmware install a few files here", but is totally
> firmware-agnostic per se.
>
> In other words, you migth just rename the "OF" functionality as "platform"
> functionality, and add dummy (empty) platform handlers for the other
> platforms (eg BIOS/EFI whatever). Maybe some day EFI will want to have a
> similar pointer..
>
> So while I'd hate to have the PCI layer start having to learn details of
> all the platforms out there, I don't think it's necessarily wrong that the
> PCI layer knows about the _concept_ of a platform, as long as it doesn't
> get too specific.
>
> Would that suit your needs?
What about adding a pcibios_add_platform_entries(device) called by
pci_sysfs then ? By default an empty inline on asm/* and on PPC,
I can add my devspec without having OF-aware code in drivers/pci
Also, if you prefer a different name for "devspec", speak up now ;)
I can still change the name in the macio devices too, nothing uses
them right now and I expect things that will be fixed to use them
to rely on 2.6.3 minimum.
Ben.
next prev parent reply other threads:[~2004-02-05 0:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-04 7:12 [PATCH] PCI / OF linkage in sysfs Benjamin Herrenschmidt
2004-02-04 22:08 ` Linus Torvalds
2004-02-04 23:13 ` Greg KH
2004-02-04 23:28 ` Benjamin Herrenschmidt
2004-02-04 23:39 ` Greg KH
2004-02-04 23:28 ` Linus Torvalds
2004-02-04 23:38 ` Greg KH
2004-02-04 23:50 ` Benjamin Herrenschmidt
2004-02-05 0:04 ` Linus Torvalds
2004-02-05 0:13 ` Benjamin Herrenschmidt [this message]
2004-02-05 0:39 ` Linus Torvalds
2004-02-05 0:50 ` Benjamin Herrenschmidt
2004-02-05 15:08 ` Eric W. Biederman
2004-02-04 23:26 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1075939994.4371.58.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox