From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Greg KH <greg@kroah.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] PCI / OF linkage in sysfs
Date: Thu, 05 Feb 2004 11:50:53 +1100 [thread overview]
Message-ID: <1075942252.4029.64.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.58.0402041634440.2086@home.osdl.org>
> Maybe just "platform-data" or something. But if "devspec" has magic
> meaning on a Mac, and since this would be inherently platform-specific
> _anyway_, I don't actually see any reason to not use "devspec".
No, no magic. Could have been "OF_path" but uppercase are ugly :)
> On some platforms, we might have multiple different entries (eg on a PC we
> might have pointers to ACPI data, to PnP data and to EFI data, all at the
> same time. I hope we never will, but maybe there would be reason for it).
> That would argue _against_ a "generic" name like "platform", and for
> something that is actually very much specific to the kind of data it
> points to (eg "of-data" rather than "platform-data").
Maybe anything prefixed by "platform" ? like "platform-fwpath" for OF
spec, etc...
> End result: I don't think we much care about the name. Whatever makes you
> happy. As long as the source code is clean and something like
> "pcibios_add_platform_entries()" at least makes that come true.
Ok. I dislike #ifdef's too indeed. I was probably too lazy to add the
empty inline to all archs :) I'll do a new patch.
Ben.
next prev parent reply other threads:[~2004-02-05 1:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-04 7:12 [PATCH] PCI / OF linkage in sysfs Benjamin Herrenschmidt
2004-02-04 22:08 ` Linus Torvalds
2004-02-04 23:13 ` Greg KH
2004-02-04 23:28 ` Benjamin Herrenschmidt
2004-02-04 23:39 ` Greg KH
2004-02-04 23:28 ` Linus Torvalds
2004-02-04 23:38 ` Greg KH
2004-02-04 23:50 ` Benjamin Herrenschmidt
2004-02-05 0:04 ` Linus Torvalds
2004-02-05 0:13 ` Benjamin Herrenschmidt
2004-02-05 0:39 ` Linus Torvalds
2004-02-05 0:50 ` Benjamin Herrenschmidt [this message]
2004-02-05 15:08 ` Eric W. Biederman
2004-02-04 23:26 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1075942252.4029.64.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox