From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/char/vt possible race
Date: Tue, 10 Feb 2004 16:28:13 +1100 [thread overview]
Message-ID: <1076390892.886.33.camel@gaston> (raw)
In-Reply-To: <20040209203424.3fc85842.akpm@osdl.org>
On Tue, 2004-02-10 at 15:34, Andrew Morton wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > Hi !
> >
> > I falled again on the crash in con_do_write() with driver->data
> > beeing NULL. It happens during boot, when userland is playing
> > open/close games with tty's, I was intentionally typing keys like
> > mad during boot trying to trigger another problem when this one
> > poped up.
>
> OK. Was this patch confirmed to prevent any reoccurrences?
Well, I didn't see it again, and if for some reason, we still
enter the function with tty->driver_data == NULL (which may still
happen if the tty layer itself isn't serializing, which I suspect),
we will print a warning and bail out.
In the end, I suppose the warning can be removed, but I want to
make sure that if the race still happens, we behave properly now.
The patch makes sure the vt internal state stays consistent.
> > Andrew: I suggest putting that in -mm for a while, and if it
> > doesn't trigger any new problem, upstream, maybe without my
> > 2 printk's "argh" :)
>
> Yup. I'll also bring back the sysfs patch which somehow triggers
> this race.
Yup, let me know.
Ben.
prev parent reply other threads:[~2004-02-10 5:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 4:20 [PATCH] drivers/char/vt possible race Benjamin Herrenschmidt
2004-02-10 4:34 ` Andrew Morton
2004-02-10 5:28 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1076390892.886.33.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox