From: Marius Zachmann <mail@mariuszachmann.de>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang
Date: Sat, 06 Mar 2021 11:39:35 +0100 [thread overview]
Message-ID: <107682713.BXpLqza3Di@marius> (raw)
In-Reply-To: <20210305095359.GA141682@embeddedor>
On 06.03.21 at 10:53:59 CET, Gustavo A. R. Silva wrote
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: Marius Zachmann <mail@mariuszachmann.de>
> ---
> drivers/hwmon/corsair-cpro.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
> index 591929ec217a..fa6aa4fc8b52 100644
> --- a/drivers/hwmon/corsair-cpro.c
> +++ b/drivers/hwmon/corsair-cpro.c
> @@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type,
> default:
> break;
> }
> + break;
> default:
> break;
> }
>
next prev parent reply other threads:[~2021-03-06 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 9:53 [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-06 10:39 ` Marius Zachmann [this message]
2021-03-08 21:15 ` Gustavo A. R. Silva
2021-05-18 0:44 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=107682713.BXpLqza3Di@marius \
--to=mail@mariuszachmann.de \
--cc=gustavoars@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox