Re: 2.6.3-rc3 radeonfb: Problems with new (and old) driver

Benjamin Herrenschmidt
2004-02-16T22:58:45Z

> I don't see that anybody else can possibly care. In fact, I doubt even
> vgacon actually cares. It's just a regular unblank, but with the
> information that we came from graphics mode. I think it would be cleaner
> to add a new parameter to the "con_blank()" function, which would also
> cause compiler warnings for non-converted consoles, which is good.
>
That's what I was talking about: what drivers should I convert :) On
PPC, I don't build things like vgacon etc... Anyway, patch coming soon.

Note that a mode_switch separate from blank would have made sense
too some way...

> Right now we encode multiple things into the one existing "blank"
> parameter, which is just confusing. We have
>
> -1: /* enter graphics mode (just save whatever state we need to save,
> possibly clear state to be polite) */

And make sure accel engine is idle...

> 0: /* regular unblank (restore screen contents, enable backlight) */
> 1: /* regular blank */
> 2..x: VESA blank type x-1.
>
> and I'd suggest that the new case would be the "regular unblank", but with
> the new parameter saying that we're coming from graphics mode. For
> example, I don't think the vgacon_blank() function would change at _all_
> (except for the new parameter that it would just ignore).
>
> As far as I can tell, fbcon is the _only_ thing that wouldn't ignore the
> new information, exactly because fbcon might want to reset things like the
> graphics engine.

Yup.

Ben.