Re: 2.6.3-rc3 radeonfb: Problems with new (and old) driver

Benjamin Herrenschmidt
2004-02-16T22:18:51Z

On Tue, 2004-02-17 at 09:13, Linus Torvalds wrote:
> On Tue, 17 Feb 2004, Benjamin Herrenschmidt wrote:
> >
> > Do we want to pay the cost (in time) of a full mode set + engine reset
> > on each unblank ? I could limit myself to restoring the accel engine,
> > that faster, but with X also not always restoring the console mode
> > properly, I'd have preferred re-setting the whole mode...
>
> Well, on blanking, we do actually already pass in a parameter that says
> "this is not a full blank, it's just a move to graphics mode". It would
> make 100% sense to add the _same_ parameter to the unblank code.
>
> That would just make the code more logical, and it should fix your
> concerns, no?

Yes, I was looking into this at the moment. Who else but fbcon and
vgacon will need fixing ? I suppose all the xxxxcon in
drivers/video/console, do you "see" any other ?

Ben.