Re: 2.6.3-rc3 radeonfb: Problems with new (and old) driver

Linus Torvalds
2004-02-16T17:56:30Z

On Mon, 16 Feb 2004, Benjamin Herrenschmidt wrote:
>
> No, it's not. I posted a patch fixing that. Enclosed again below.

I don't think this is right.

It gets the same-tty case wrong, and the reason it gets it wrong is that
it does its thing in entirely the wrong place.

The console layer already always calls "unblank_screen()" on any switch to
text mode, _regardless_ of whether it was switching from another console
or not. That should be the place where this is done, and perhaps by
changing the console layer to be a bit more helpful about things (mainly
re-name the damn thing, since it has nothing to do with "unblank" any
more).

"unblank_screen()" is really the same as "reset_screen" - it's also called
on resume. While "do_blank_screen()" is basically "go away".

So why don't you just reset the thing in "con_blank()" that gets called in
all the right cases?

Linus