The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Christophe Saout <christophe@saout.de>
To: Jamie Lokier <jamie@shareable.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	LKML <linux-kernel@vger.kernel.org>,
	pavel@suse.cz
Subject: Re: kthread, signals and PF_FREEZE (suspend)
Date: Mon, 16 Feb 2004 18:12:05 +0100	[thread overview]
Message-ID: <1076951524.5881.1.camel@leto.cs.pocnet.net> (raw)
In-Reply-To: <20040216165329.GB17323@mail.shareable.org>

Am Mo, den 16.02.2004 schrieb Jamie Lokier um 17:53:

> Rusty Russell wrote:
> > > That means that signal_pending() will return true for that process which
> > > will make kthread stop the thread.
> > 
> > Yes, the way they are currently coded.  I had assumed that spurious
> > signals do not occur.
> 
> Yowch.  Does suspend mean this warning in futex_wait is wrong?
> 
> 	/* A spurious wakeup should never happen. */
> 	WARN_ON(!signal_pending(current));
> 	return -EINTR;

I just tried it on my notebook. It works, no warning.

I don't know how things work exactly. There is some stuff in the arch
signal.c in do_signal that also handles PF_FREEZE.



  reply	other threads:[~2004-02-16 17:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-16  0:18 kthread, signals and PF_FREEZE (suspend) Christophe Saout
2004-02-16  3:38 ` Rusty Russell
2004-02-16  9:55   ` Pavel Machek
2004-02-16 13:36   ` Christophe Saout
2004-02-16 16:53   ` Jamie Lokier
2004-02-16 17:12     ` Christophe Saout [this message]
2004-02-17  4:44     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1076951524.5881.1.camel@leto.cs.pocnet.net \
    --to=christophe@saout.de \
    --cc=jamie@shareable.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox