From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Santiago Leon <santil@us.ibm.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH][2.6] IBM PowerPC Virtual Ethernet Driver
Date: Wed, 18 Feb 2004 11:45:20 +1100 [thread overview]
Message-ID: <1077065118.1082.83.camel@gaston> (raw)
In-Reply-To: <40329A24.5070209@us.ibm.com>
On Wed, 2004-02-18 at 09:48, Santiago Leon wrote:
> Here's a patch that adds the inter-partition Virtual Ethernet driver for
> newer IBM iSeries and pSeries systems:
>
> The patch applies against 2.6.3-rc3...
>
> Jeff, can you formally add this driver to 2.6?... The differences
> between this driver and the 2.4 driver that you accepted are fairly
> trivial (i.e. workqueues instead of tasklets)... The architectural
> additions that I was waiting for have been applied to the mainline tree...
>
> Comments and suggestions are always welcome...
Let me put my though police hat for a short while...
BITFIELDS ARE EVIL !!!
Especially when mapping things like HW registers... I know the p/iSeries
code is full of them, I'd strongly recommend getting rid of them.
The compiler is perfectly free, afaik, to re-order them, you have no
guarantee of your actual layout, and it's not portable (I know nothing
but PPC uses those drivers _right_ now, but still...)
So please, don't add more ;)
Ben.
next prev parent reply other threads:[~2004-02-18 0:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-17 22:48 [PATCH][2.6] IBM PowerPC Virtual Ethernet Driver Santiago Leon
2004-02-18 0:45 ` Benjamin Herrenschmidt [this message]
2004-02-18 4:01 ` Dave Jones
2004-02-18 4:23 ` viro
2004-02-18 4:46 ` Linus Torvalds
2004-02-18 5:03 ` Benjamin Herrenschmidt
2004-02-18 16:39 ` Linus Torvalds
2004-02-18 5:04 ` viro
2004-02-18 4:19 ` Keith Owens
2004-02-18 4:42 ` Andrew Morton
2004-02-18 4:48 ` Linus Torvalds
2004-02-20 23:26 ` Santiago Leon
2004-02-22 22:11 ` Pavel Machek
2004-02-26 5:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1077065118.1082.83.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=santil@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox