From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: James Simmons <jsimmons@infradead.org>
Cc: "Randy.Dunlap" <rddunlap@osdl.org>,
Jonathan Brown <jbrown@emergence.uk.net>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Double fb_console_init call during do_initcalls
Date: Sat, 21 Feb 2004 10:02:38 +1100 [thread overview]
Message-ID: <1077318157.9626.23.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.44.0402201907130.6798-100000@phoenix.infradead.org>
> I seen the report and begain to create a patch. The module_init fix is
> easy. Just place module_init and module_exit under #ifdef MODULE. I
> realize alot of fbdev drivers do this wrong. I will make patches by the
> end of the day. As for the fbmem.c call on fb_console_init. Well that is
> tricker to deal with. I will have to figure out a way.
You can also use the fb_registered_client static I added and rename
it to fbcon_initialized ;) Dunno if we actually _need_ the second call
to take_over_console at this point, so i left it called twice, but
I needed the static to protect against registering the notifier twice
(That was what was causing the notifier list to get corrupted and
mode changes to lockup in early implementations)
Ben.
prev parent reply other threads:[~2004-02-20 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-20 12:12 Double fb_console_init call during do_initcalls Jonathan Brown
2004-02-20 18:38 ` Randy.Dunlap
2004-02-20 19:21 ` James Simmons
2004-02-20 23:02 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1077318157.9626.23.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=jbrown@emergence.uk.net \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox