From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261432AbUBTXIT (ORCPT ); Fri, 20 Feb 2004 18:08:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261433AbUBTXIT (ORCPT ); Fri, 20 Feb 2004 18:08:19 -0500 Received: from gate.crashing.org ([63.228.1.57]:48299 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S261432AbUBTXIN (ORCPT ); Fri, 20 Feb 2004 18:08:13 -0500 Subject: Re: Double fb_console_init call during do_initcalls From: Benjamin Herrenschmidt To: James Simmons Cc: "Randy.Dunlap" , Jonathan Brown , Linux Kernel list In-Reply-To: References: Content-Type: text/plain Message-Id: <1077318157.9626.23.camel@gaston> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Sat, 21 Feb 2004 10:02:38 +1100 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > I seen the report and begain to create a patch. The module_init fix is > easy. Just place module_init and module_exit under #ifdef MODULE. I > realize alot of fbdev drivers do this wrong. I will make patches by the > end of the day. As for the fbmem.c call on fb_console_init. Well that is > tricker to deal with. I will have to figure out a way. You can also use the fb_registered_client static I added and rename it to fbcon_initialized ;) Dunno if we actually _need_ the second call to take_over_console at this point, so i left it called twice, but I needed the static to protect against registering the notifier twice (That was what was causing the notifier list to get corrupted and mode changes to lockup in early implementations) Ben.