From: James Bottomley <James.Bottomley@steeleye.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
willy@debian.org, Jes Sorensen <jes@wildopensource.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] move dma_consistent_dma_mask to the generic device
Date: 25 Feb 2004 20:55:58 -0600 [thread overview]
Message-ID: <1077764159.14043.28.camel@mulgrave> (raw)
In-Reply-To: <20040225180600.273bbf55.akpm@osdl.org>
On Wed, 2004-02-25 at 20:06, Andrew Morton wrote:
> A bit more grepping is needed.
>
> sound/core/memalloc.c: In function `snd_pci_hack_alloc_consistent':
> sound/core/memalloc.c:103: structure has no member named `consistent_dma_mask'
Mea culpa, I don't have any boxes that define this hack, so I didn't see
it. This sound memalloc is horribly illegal under the API...I suppose
we're just lucky the Altix doesn't have a sound card ;-)
This incremental patch should fix it up (I compiled it on parisc by
including it in the hacked architectures).
James
===== sound/core/memalloc.c 1.16 vs edited =====
--- 1.16/sound/core/memalloc.c Mon Jan 19 04:37:35 2004
+++ edited/sound/core/memalloc.c Wed Feb 25 20:51:28 2004
@@ -100,13 +100,13 @@
if (hwdev == NULL)
return pci_alloc_consistent(hwdev, size, dma_handle);
dma_mask = hwdev->dma_mask;
- cdma_mask = hwdev->consistent_dma_mask;
+ cdma_mask = hwdev->dev.coherent_dma_mask;
mask = (unsigned long)dma_mask && (unsigned long)cdma_mask;
hwdev->dma_mask = 0xffffffff; /* do without masking */
- hwdev->consistent_dma_mask = 0xffffffff; /* do without masking */
+ hwdev->dev.coherent_dma_mask = 0xffffffff; /* do without masking */
ret = pci_alloc_consistent(hwdev, size, dma_handle);
hwdev->dma_mask = dma_mask; /* restore */
- hwdev->consistent_dma_mask = cdma_mask; /* restore */
+ hwdev->dev.coherent_dma_mask = cdma_mask; /* restore */
if (ret) {
/* obtained address is out of range? */
if (((unsigned long)*dma_handle + size - 1) & ~mask) {
next prev parent reply other threads:[~2004-02-26 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-26 1:34 [PATCH] move dma_consistent_dma_mask to the generic device James Bottomley
2004-02-26 2:06 ` Andrew Morton
2004-02-26 2:55 ` James Bottomley [this message]
2004-03-03 15:29 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1077764159.14043.28.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=jes@wildopensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox