From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@osdl.org>
Subject: Re: ppc64: fix non-iSeries build
Date: Sat, 28 Feb 2004 09:13:56 +1100 [thread overview]
Message-ID: <1077920035.23344.9.camel@gaston> (raw)
In-Reply-To: <200402271911.i1RJBhnA031450@hera.kernel.org>
> diff -Nru a/arch/ppc64/kernel/iSeries_iommu.c b/arch/ppc64/kernel/iSeries_iommu.c
> --- a/arch/ppc64/kernel/iSeries_iommu.c Fri Feb 27 11:11:47 2004
> +++ b/arch/ppc64/kernel/iSeries_iommu.c Fri Feb 27 11:11:47 2004
> @@ -58,8 +58,16 @@
> static struct pci_dev _veth_dev = { .sysdata = &veth_dev_node };
> static struct pci_dev _vio_dev = { .sysdata = &vio_dev_node, .dev.bus = &pci_bus_type };
>
> +/*
> + * I wonder what the deal is with these. Nobody uses them. Why do they
> + * exist? Why do we export them to modules? Why is this comment here, and
> + * why didn't I just delete them?
> + */
They are, I think, used by iSeries virtual ethernet & virtual disk
drivers. I'll heck with Stephen on monday what's up exactly.
Note, there's also that small hash table management fix for iSeries
that i posted yesterday that should get in. Withiout it, iSeries will
blow up on moderate load rather quickly.
Ben.
parent reply other threads:[~2004-02-27 22:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200402271911.i1RJBhnA031450@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1077920035.23344.9.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox