Re: [patch] new version, u64 cast avoidance

Albert Cahalan
2004-02-29T00:41:20Z

On Sat, 2004-02-28 at 18:59, Benjamin Herrenschmidt wrote:
> On Sun, 2004-02-29 at 10:58, Benjamin Herrenschmidt wrote:
> > > asm-ppc64/types.h | 14 ++++++++++++--
> >
> > Please, do not mess with ppc64 at this point, I'm not sure
> > I like the approach anyway, I can live with some warnings
> > in printk...
>
> I meant some casts of course ;)

If only those were casts under arch/ppc64, sure.
All 32-bit ports and x86-64 are being affected.
Besides being ugly and verbose, the current situation
isn't type-safe.

I'd be interested to hear why you don't like the
approach, and interested to hear your alternatives.
For example:

a. my solution, as given
b. move u64 and friends to include/linux/*.h
c. you promise to never complain about warnings
d. printk("Ugly: " U64_FMT "\n", some_u64_value);
e. you patch gcc to modify format strings :-)
f. ...

In other words, how do you propose to eliminate
the casts?