public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: "debian-powerpc@lists.debian.org"
	<debian-powerpc@lists.debian.org>,
	"Linux Kernel list" <linux-kernel@vger.kernel.org>,
	"Matthias Urlichs" <smurf@smurf.noris.de>,
	"Martin-Éric Racine" <q-funk@pp.fishpool.fi>
Subject: Re: [PATCH] For test only: pmac_zilog fixes (cups lockup at boot):
Date: Fri, 05 Mar 2004 20:29:12 +1100	[thread overview]
Message-ID: <1078478951.5698.82.camel@gaston> (raw)
In-Reply-To: <20040305092422.C22156@flint.arm.linux.org.uk>


> Yes, I know - but the point is its impossible to review, and I think
> you at least have an extra level of locking which isn't needed.
> 
> But I wouldn't know because of the huge number of changes which make
> it impossible to read.

That semaphore locking is only used to guard open/close against the
power management callback. It greatly simplify the deal with the shared
irq (the irq is shared between both ports). It's not used during
normal operations.

Ben.



  reply	other threads:[~2004-03-05  9:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-05  7:54 [PATCH] For test only: pmac_zilog fixes (cups lockup at boot): Benjamin Herrenschmidt
2004-03-05  8:58 ` Russell King
2004-03-05  9:02   ` Benjamin Herrenschmidt
2004-03-05  9:18     ` serial driver / tty issues Benjamin Herrenschmidt
2004-03-05  9:41       ` Russell King
2004-03-05 11:13         ` Benjamin Herrenschmidt
2004-03-05  9:05   ` [PATCH] For test only: pmac_zilog fixes (cups lockup at boot): Benjamin Herrenschmidt
2004-03-05  9:24     ` Russell King
2004-03-05  9:29       ` Benjamin Herrenschmidt [this message]
2004-03-05  9:48         ` Russell King
2004-03-05 11:14           ` Benjamin Herrenschmidt
2004-03-05 17:52           ` Matthias Urlichs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1078478951.5698.82.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=debian-powerpc@lists.debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=q-funk@pp.fishpool.fi \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=smurf@smurf.noris.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox